Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: ttl: Remove ttl_range_concurrency config #90294

Merged
merged 1 commit into from
Oct 20, 2022
Merged

release-22.2: ttl: Remove ttl_range_concurrency config #90294

merged 1 commit into from
Oct 20, 2022

Conversation

ecwall
Copy link
Contributor

@ecwall ecwall commented Oct 19, 2022

fixes #89393

see #89392 for benchmarking

To simplify TTL setup, range concurrency is set to min(num_spans, num_cpus)
in each processor instead of letting the user set it.

Release note (sql change): Cluster setting sql.ttl.default_range_concurrency
and table storage param ttl_range_concurrency are no longer configurable.

Release justification: Simplifies TTL config and improves TTL workload and tests.

/cc @cockroachdb/release

fixes #89393

see #89392 for benchmarking

To simplify TTL setup, range concurrency is set to min(num_spans, num_cpus)
in each processor instead of letting the user set it.

Release note (sql change): Cluster setting sql.ttl.default_range_concurrency
and table storage param ttl_range_concurrency are no longer configurable.
@ecwall ecwall requested a review from a team as a code owner October 19, 2022 21:27
@ecwall ecwall requested review from a team October 19, 2022 21:27
@ecwall ecwall requested review from a team as code owners October 19, 2022 21:27
@blathers-crl
Copy link

blathers-crl bot commented Oct 19, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@ecwall ecwall requested a review from rafiss October 19, 2022 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants