release-22.2.0: backupccl: use the backup codec when inspecting spans in the backupManifest #90528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
…nifest Informs #90475, #90474 Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in #90475, #90474 could manifest. This patch fixes these bugs.
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2.0-90477
branch
from
db86613
to
e153157
Compare
blathers-crl
bot
requested review from
benbardin,
adityamaru,
dt,
msbutler and
stevendanna
blathers-crl
bot
added
blathers-backport
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
|
This change is |
dt
approved these changes
Oct 24, 2022
|
note for docs: this shouldn't have a release note. |
This was referenced Oct 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #90477 on behalf of @msbutler.
/cc @cockroachdb/release
Informs #90475, #90474
Release note (bug fix): previously, during restore planning, the restoring cluster's codec was accidentally used to reason about spans in the backup manifest. When a backup was restored by a different tenant, two bugs described in #90475, #90474 could manifest. This patch fixes these bugs.
Release justification: bug fix