release-22.2: sql/opt: propagate mutation state for virtual columns #91007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
blathers-crl
bot
force-pushed
the
blathers/backport-release-22.2-90670
branch
from
f2c8c6f
to
a45d976
Compare
|
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
blathers-crl
bot
requested review from
chengxiong-ruan,
fqazi,
mgartner and
rytaft
blathers-crl
bot
added
blathers-backport
|
This change is |
rytaft
approved these changes
Oct 31, 2022
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan, @fqazi, and @mgartner)
fqazi
force-pushed
the
blathers/backport-release-22.2-90670
branch
3 times, most recently
from
636c9a1
to
b74da15
Compare
Fixes: #90570 Previously, the mutation state was not properly propagated for virtual columns, so during active schema changes certain queries could potentially fail. This was inadequate when a cascaded drop columns occurred for any column with a virtual column dependent, since during a "SELECT *" the optimizer would treat the virtual column as readable (even though the dependents for it were not accessible). To address this, this patch will propagate the mutation state for virtual computed columns. Release note (bug fix): SELECT * operations on tables with virtual computed columns undergoing schema changes could potentially fail.
fqazi
force-pushed
the
blathers/backport-release-22.2-90670
branch
from
b74da15
to
42a2d0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #90670 on behalf of @fqazi.
/cc @cockroachdb/release
Fixes: #90570
Previously, the mutation state were not properly propagated for virtual columns, so during active schema changes certain queries could potentially fail. This was inadequate specifically when problematic if we had cascaded drop columns, where a virtual column could be dropped as a side effect. It was possible for "SELECT *" to fail in certain scenarios. To address this, this patch will propogate the mutation state for virtual computed columns.
Release note (bug fix): SELECT * operations on tables with virtual computed columns under going schema changes could potentially fail.
Release justification: low risk fix that addresses query errors during schema changes.