Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2.0: metrics: add tsdb persistence to AggHistogram #91410

Merged

Conversation

dhartunian
Copy link
Collaborator

@dhartunian dhartunian commented Nov 7, 2022

Backport 1/1 commits from #90769.

/cc @cockroachdb/release


Previously, AggHistogram instances would not persist their quantiles to tsdb due to a missing interface implementation of metrics.WindowedHistogram. This PR adds a trivial implementation that delegates to the aggregate histogram instance within the struct.

This is relatively safe to do even though an AggHistogram could contain many children because we are only exporting a single set of aggregate quantiles per-AggHistogram. The children are only iterated over via the PrometheusIterable interface which is used by the prometheus exporter, but not by the metrics recorder.

NOTE: This backported commit includes a test fix to the kv package that was
lifted from #88076.

Release note (bug fix, ops change): Previously, certain aggregate histograms would appear in _status/vars but not be available for graphing in the DB Console. These are now made available. They include changefeed-related histograms, and row-level-TTL histograms.

Epic: None

Release Justification: Category 3: Fixes for high-priority or high-severity bugs in existing functionality

@dhartunian dhartunian requested a review from a team as a code owner November 7, 2022 16:26
@blathers-crl
Copy link

blathers-crl bot commented Nov 7, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@abarganier abarganier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @rafiss)

Copy link
Collaborator

@nkodali nkodali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @rafiss)

@dhartunian
Copy link
Collaborator Author

Added port of test fixes from #88076 and added a note to that regard to PR+commit.

Previously, `AggHistogram` instances would not persist their quantiles to tsdb
due to a missing interface implementation of `metrics.WindowedHistogram`. This
PR adds a trivial implementation that delegates to the aggregate histogram
instance within the struct.

This is relatively safe to do even though an `AggHistogram` could contain many
children because we are only exporting a single set of aggregate quantiles
per-`AggHistogram`. The children are only iterated over via the
`PrometheusIterable` interface which is used by the prometheus exporter, but
not by the metrics recorder.

NOTE: This backported commit includes a test fix to the `kv` package that was
lifted from cockroachdb#88076.

Release note (bug fix, ops change): Previously, certain aggregate histograms
would appear in `_status/vars` but not be available for graphing in the DB
Console. These are now made available. They include changefeed-related
histograms, and row-level-TTL histograms.

Epic: None
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants