ccl/jwtauthccl: allow tenants to set jwt auth settings #92406
Merged
+4
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kpatron-cockroachlabs
force-pushed
the
kpatron/tenant-writable-jwt-settings
branch
from
9699e4f
to
b060627
Compare
|
bors r+ |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed (retrying...): |
|
Build failed: |
|
bors r- |
kpatron-cockroachlabs
force-pushed
the
kpatron/tenant-writable-jwt-settings
branch
2 times, most recently
from
c76f2be
to
ff83994
Compare
Previously, tenants were prevented from modifying the cluster settings that controlled jwt based auth. This prevented these customers from using external signers and made it more complicated for us to support CC serverless cluster SSO. This change makes it so that tenants can configure their JWT auth cluster settings. This paves the way for full support of cluster SSO in severless. Fixes CC-8608. Release note (enterprise change): JWT authentication cluster settings can now be modified from within tenants to better support serverless use cases.
kpatron-cockroachlabs
force-pushed
the
kpatron/tenant-writable-jwt-settings
branch
from
ff83994
to
4b4d925
Compare
|
bors r+ |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, tenants were prevented from modifying the cluster settings that controlled jwt based auth. This prevented these customers from using external signers and made it more complicated for us to support CC
serverless cluster SSO.
This change makes it so that tenants can configure their JWT auth cluster settings. This paves the way for full support of cluster SSO in severless.
Release note (enterprise change): JWT authentication cluster settings can now be modified from within
tenants to better support serverless use cases.