roachtest: add failover/non-system/blackhole tests
#92991
Conversation
|
This change is |
erikgrinaker
force-pushed
the
roachtest-blackhole
branch
3 times, most recently
from
36bbf4c
to
4052f8e
Compare
Epic: None Release note: None
erikgrinaker
force-pushed
the
roachtest-blackhole
branch
from
4052f8e
to
9aa0078
Compare
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @erikgrinaker)
pkg/cmd/roachtest/tests/failover.go line 81 at r2 (raw file):
require.Equal(t, 7, c.Spec().NodeCount) seed := int64(1666467482296309000)
Add a comment here that you wanted predictable randomness.
erikgrinaker
force-pushed
the
roachtest-blackhole
branch
from
9aa0078
to
4e11e2a
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/failover.go line 81 at r2 (raw file):
Previously, tbg (Tobias Grieger) wrote…
Add a comment here that you wanted predictable randomness.
Not sure that we do, on second thought. There's enough randomness in the environment here that it likely doesn't matter. Switched it to NewTestRand().
erikgrinaker
force-pushed
the
roachtest-blackhole
branch
from
4e11e2a
to
e22273e
Compare
This patch adds roachtests to benchmark the maximum unavailability during leaseholder network outages on non-system ranges, both symmetric and asymmetric outages. Initial results, with a query timeout of 30 s: | Test | pMax read | pMax write | |------------------|-----------|------------| | `crash` | 14.5 s | 14.5 s | | `blackhole` | 16.6 s | 18.3 s | | `blackhole-recv` | 30.1 s | 30.1 s | | `blackhole-send` | 30.1 s | 30.1 s | Epic: None Release note: None
erikgrinaker
force-pushed
the
roachtest-blackhole
branch
from
e22273e
to
51b7e62
Compare
|
CI failures appear unrelated. bors r+ |
|
Build failed: |
|
bors retry |
|
Build failed: |
|
bors retry |
|
Build succeeded: |
This patch adds roachtests to benchmark the maximum unavailability during leaseholder network outages on non-system ranges, both symmetric and asymmetric outages. Initial results, with a query timeout of 30 s:
crashblackholeblackhole-recvblackhole-sendTouches #79494.
Epic: None
Release note: None