Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: upgrade etcd/raft to 8651478c #93066

Merged
merged 3 commits into from
Dec 6, 2022
Merged

*: upgrade etcd/raft to 8651478c #93066

merged 3 commits into from
Dec 6, 2022

Conversation

pav-kv
Copy link
Collaborator

@pav-kv pav-kv commented Dec 5, 2022 •
edited
Loading

This is the latest version of etcd/raft before it moves to a separate repository and changes the module path.

Fixes #91605
Epic: None

@pav-kv pav-kv requested a review from tbg December 5, 2022 19:21
@pav-kv pav-kv requested a review from a team as a code owner December 5, 2022 19:21
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@pav-kv pav-kv closed this Dec 5, 2022
@pav-kv pav-kv deleted the update_etcd branch December 5, 2022 20:54
@pav-kv pav-kv restored the update_etcd branch December 5, 2022 20:54
@pav-kv pav-kv reopened this Dec 5, 2022
@pav-kv pav-kv requested a review from a team as a code owner December 5, 2022 20:55
@pav-kv pav-kv changed the title *: upgrade etcd/raft to 26c06277 *: upgrade etcd/raft to 8651478c Dec 5, 2022
@pav-kv
Copy link
Collaborator Author

pav-kv commented Dec 5, 2022 •
edited
Loading

@nvanbenschoten Please review the second commit. Is the new usage of nullable Snapshot correct (introduced in etcd-io/etcd#14592)?

@pav-kv
Copy link
Collaborator Author

pav-kv commented Dec 5, 2022

@tbg Please make sure that the first commit correctly reverts 2c1c354.

@pav-kv pav-kv force-pushed the update_etcd branch 2 times, most recently from e7b2849 to def7d77 Compare December 6, 2022 10:37
@pav-kv
Update etcd/raft to 2a1055c7
0a43332 
This change imports etcd/raft at 2a1055c7 and removes the no longer necessary
custom build patch. It also fixes usages of the new max-bytes inflight limiter.

Release note: none
Epic: none
@pav-kv
Update etcd/raft to 285e4437
e532c65 
This change imports etcd/raft at 285e4437, and fixes the usage of now nillable
Snapshot field.

Release note: none
Epic: none
@pav-kv
Update etcd/raft to 8651478c
736c1ed 
Release note: none
Epic: none
tbg
tbg approved these changes Dec 6, 2022
View reviewed changes
Copy link
Member

@tbg tbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great to have a clean dependency without any workarounds.

@pav-kv
Copy link
Collaborator Author

pav-kv commented Dec 6, 2022

bors r=tbg

@craig
Copy link
Contributor

craig bot commented Dec 6, 2022

Build succeeded:

@craig craig bot merged commit 25c2b9e into cockroachdb:master Dec 6, 2022
@pav-kv pav-kv deleted the update_etcd branch December 6, 2022 14:42
@pav-kv pav-kv mentioned this pull request Dec 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbg tbg tbg approved these changes

@nvanbenschoten nvanbenschoten Awaiting requested review from nvanbenschoten

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

go.mod: remove custom patch for raft
3 participants
@pav-kv @cockroach-teamcity @tbg