Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: backupccl: speed up listing in some backup callsites #93204

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Dec 7, 2022

Backport 1/1 commits from #93072 on behalf of @adityamaru.

/cc @cockroachdb/release


There were a couple of calls to List that would list all the files in the backup destination bucket. In the presence of a large number of files, usually SST files in the data/ folder, this listing could be very slow. This could manifest as a RESTORE command hanging during the planning phase when we go to resolve encryption information from the base backup bucket.

To fix this, we add a delimiter to the List call that will make skipping over all files in the data/ directory much cheaper.

Informs: https://github.com/cockroachlabs/support/issues/1937

Release note (bug fix): speedup slow listing calls that could manifest as restore queries hanging during execution, in the presence of several backup files


Release justification: low risk change with high impact for customers restoring from buckets with a large number of files

There were a couple of calls to `List` that would list all
the files in the backup destination bucket. In the presence of a
large number of files, usually SST files in the `data/` folder, this
listing could be very slow. This could manifest as a RESTORE command
hanging during the planning phase when we go to resolve encryption information
from the base backup bucket.

To fix this, we add a `delimiter` to the `List` call that will make
skipping over all files in the `data/` directory much cheaper.

Informs: https://github.com/cockroachlabs/support/issues/1937

Release note (bug fix): speedup slow listing calls that could manifest
as restore queries hanging during execution, in the presence of several
backup files
@blathers-crl blathers-crl bot requested a review from a team as a code owner December 7, 2022 18:02
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-93072 branch from 06b84ea to 5ffc93f Compare December 7, 2022 18:02
@blathers-crl blathers-crl bot requested review from msbutler and dt and removed request for a team December 7, 2022 18:02
@blathers-crl
Copy link
Author

blathers-crl bot commented Dec 7, 2022

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Dec 7, 2022
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@adityamaru adityamaru merged commit 98f59e8 into release-22.2 Dec 7, 2022
@adityamaru adityamaru deleted the blathers/backport-release-22.2-93072 branch December 7, 2022 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants