Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-22.2: tochar: implement cache for parse format #93330

Merged
merged 1 commit into from
Dec 13, 2022
Merged

release-22.2: tochar: implement cache for parse format #93330

merged 1 commit into from
Dec 13, 2022

Commits on Dec 9, 2022

  1. tochar: implement cache for parse format 

    Implemented a basic cache for parse formats, similar to `ReCache`.
Haven't done any memory monitoring as the space this takes is
predictable - cache size * maxCacheKeySize * some constant for vars.

Before:
```
BenchmarkTimeToChar-10        	  761224	      1577 ns/op
BenchmarkIntervalToChar-10    	  552865	      2226 ns/op
```

After:
```
BenchmarkTimeToChar-10        	 1719128	       702.8 ns/op
BenchmarkIntervalToChar-10    	 1551093	       771.4 ns/op
```

Release note (sql change, performance improvement): `to_char` now has
caching for parse formats, marking a speedup when running to_char with
the same format between sessions.
    @otan
    otan committed Dec 9, 2022
    Configuration menu
    Copy the full SHA
    6a07d2b View commit details
    Browse the repository at this point in the history