New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: ui: install Cypress native binary just in time #93803
Conversation
f2a1156
to
5744494
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
Thanks for the quick re-review, @rickystewart ! bors r=rickystewart |
bors r- |
Canceled. |
No bors on release branches. :) Just click the merge button when checks have passed. |
Reminder: it has been 3 weeks please merge or close your backport! |
It looks like 22.2.8 doesn't have this fix. Is it going to be in a future release? (Still hitting #93162 trying to build 22.2.8.) |
😓 that's very embarrassing, I forgot to merge this. Let me get it back up to date and it'll be in 22.2.9. I'm so sorry @davepacheco ! |
5744494
to
1afef1c
Compare
Previously, the native binary for the UI end-to-end testing framework Cypress[1] was installed immediately when starting any full build of CockroachDB (i.e. anything that includes the web UI). This caused errors on the non-Windows, non-Darwin, non-Linux operating systems that Cypress doesn't support[2], including FreeBSD and illumos. Since those tests aren't part of the core build or test suite, build failures are an unnecessarily harsh failure mode. Download the native Cypress binary only when necessary, restoring the ability for users on FreeBSD, illumos, and others to build CockroachDB. [1] https://cypress.io [2] https://docs.cypress.io/guides/getting-started/installing-cypress#Operating-System Fixes: #87369 Release note (build change): The native binary for Cypress is now only downloaded and installed when UI end- to-end tests are run, instead of eagerly downloading it on all platforms at build-time. This restores the ability for non-{Windows, Darwin, Linux} platforms like FreeBSD and illumos to build CRDB without modifications, which broke in the initial 22.2 release.
1afef1c
to
fe99e9a
Compare
Merged. Thanks for the reminder, @davepacheco, and sorry again for the super long delay! |
No sweat. Thanks for the fix! |
Backport 1/1 commits from #93800 on behalf of @sjbarag.
/cc @cockroachdb/release
Previously, the native binary for the UI end-to-end testing framework
Cypress[1] was installed immediately when starting any full build of
CockroachDB (i.e. anything that includes the web UI). This caused errors
on the non-Windows, non-Darwin, non-Linux operating systems that Cypress
doesn't support[2], including FreeBSD and illumos. Since those tests
aren't part of the core build or test suite, build failures are an
unnecessarily harsh failure mode. Download the native Cypress binary
only when necessary, restoring the ability for users on FreeBSD,
illumos, and others to build CockroachDB.
[1] https://cypress.io/
[2] https://docs.cypress.io/guides/getting-started/installing-cypress#Operating-System
Fixes: #87369
Release note (build change): The native binary for Cypress is now only
downloaded and installed when UI end- to-end tests are run, instead of
eagerly downloading it on all platforms at build-time. This restores
the ability for non-{Windows, Darwin, Linux} platforms like FreeBSD and
illumos to build CRDB without modifications, which broke in the initial
22.2 release.
Release justification: Non-production code changes