release-22.2: server: fix log flushDaemon incorrectly ignores syncInterval

[blathers-crl]

Backport 1/1 commits from #93956 on behalf of @srosenberg.

/cc @cockroachdb/release

---

flushDaemon runs in background and invokes lockAndFlushAndMaybeSync at every flushInterval (default is 1 second). Every syncInterval (default is 30 seconds) it's supposed to set doSync so that the subsequent call to lockAndFlushAndMaybeSync will result in file.Sync in addition to Flush.

The faulty logic caused doSync to be always false; i.e., file.Sync was never issued and may have resulted in truncated server logs. This fix restores the intended behavior, thereby issuing file.Sync at every syncInterval.

Epic: none

Release note (bug fix): server logs are now correctly fsynced at every syncInterval

---

Release justification: bug fix

[blathers-crl]

Thanks for opening a backport.

Please check the backport criteria before merging:

• Patches should only be created for serious issues or test-only changes.
• Patches should not break backwards-compatibility.
• Patches should change as little code as possible.
• Patches should not change on-disk formats or node communication protocols.
• Patches should not add new functionality.
• Patches must not add, edit, or otherwise modify cluster versions; or add version gates.

If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.

• There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
• The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
• New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
• The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

• What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
• Will this work in a cluster of mixed patch versions? Did we test that?
• If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

[cockroach-teamcity]

This change is