Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tree: fix regression in type-checking arrays with placeholders #94207

Merged
merged 1 commit into from
Dec 23, 2022

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Dec 23, 2022

fixes #94192

Release note (bug fix): Fixed a bug that could happen when type-checking an array expression that only contains NULLs and placeholder values. The bug was only present in v22.2.1.

Release note (bug fix): Fixed a bug that could happen when type-checking
an array expression that only contains NULLs and placeholder values. The
bug was only present in v22.2.1.
@rafiss rafiss requested a review from a team as a code owner December 23, 2022 07:59
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Member

@jordanlewis jordanlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are you like this, type checking 😭

@rafiss
Copy link
Collaborator Author

rafiss commented Dec 23, 2022

tftr!

bors r+

@craig
Copy link
Contributor

craig bot commented Dec 23, 2022

Build succeeded:

@craig craig bot merged commit 6e4c565 into cockroachdb:master Dec 23, 2022
@rafiss rafiss deleted the fix-array-with-nulls-type-check branch December 23, 2022 22:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Something broke with the inet data type
3 participants