pkg/cli: add tenant ID filter flag to debug merge-logs
#95016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
abarganier
force-pushed
the
merge-logs-tenant-filter
branch
from
d5aa17f
to
f46c789
Compare
dhartunian
approved these changes
Jan 12, 2023
There was a problem hiding this comment.
Reviewed 4 of 4 files at r1, 2 of 2 files at r2, 31 of 31 files at r3.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @aadityasondhi)
abarganier
force-pushed
the
merge-logs-tenant-filter
branch
2 times, most recently
from
5b759d8
to
0885f22
Compare
With multiple tenants running per-process, log files are shared between tenants where tenant ID tags are used to distinguish which tenant a log entry originated from. When dealing with logs, especially in a debug.zip bundle, we need to provide tools that make it easy to filter logs to a specific tenant, or group of tenants. This patch updates the `debug merge-logs` command with a `--tenant-ids` flag which can be used to filter merged logs to specific tenant ID(s). For example, to only include logs for app tenants 2 and 3: ``` cockroach debug merge-logs ... --tenant-ids=2,3 ``` Release note (cli change): The `debug merge-logs` CLI command is now equipped with a `--tenant-ids` flag, which can be used to provide the command with a list of tenant IDs to filter logs on. For example, to only include logs for secondary tenants 2 and 3: ``` cockroach debug merge-logs ... --tenant-ids=2,3 ``` Note that when processing logs from older cluster versions, where a tenant ID tag may not be present on the log entry, the command will interpret any log without a tenant ID as belonging to the system tenant (tenant ID = 1).
abarganier
force-pushed
the
merge-logs-tenant-filter
branch
from
0885f22
to
0195831
Compare
|
bors r=dhartunian |
|
Build failed (retrying...): |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NB: Only review the final commit - all previous commits are being reviewed in #94777
With multiple tenants running per-process, log files are
shared between tenants where tenant ID tags are used to
distinguish which tenant a log entry originated from.
When dealing with logs, especially in a debug.zip bundle,
we need to provide tools that make it easy to filter logs
to a specific tenant, or group of tenants.
This patch updates the
debug merge-logscommand with a--tenant-idsflag which can be used to filter mergedlogs to specific tenant ID(s). For example, to only include
logs for app tenants 2 and 3:
Release note (cli change): The
debug merge-logsCLI command is now equipped with a
--tenant-idsflag, which can be used to provide the command with
a list of tenant IDs to filter logs on. For example,
to only include logs for secondary tenants 2 and 3:
Note that when processing logs from older cluster
versions, where a tenant ID tag may not be present
on the log entry, the command will interpret any
log without a tenant ID as belonging to the system
tenant (tenant ID = 1).
Epic: CRDB-14486
Addresses: https://cockroachlabs.atlassian.net/browse/CRDB-22152