Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver,server: add more load stats to hot ranges v2 api #95388

Closed
wants to merge 2 commits into from

Commits on Jan 23, 2023

  1. kvserver,server: add range cpu time hotrange api

    Various range load statistics such as read(write) bytes(keys) exist on
    the hot ranges (v1) and range statistics api. This commit adds the
    additional statistic, `CPUTimePerSecond`. This statistic is the recent
    average cpu usage per second of the range in nanoseconds.
    
    resolves: cockroachdb#95384
    
    Release note: None
    kvoli committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    1e2c06b View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. server: add more load stats to hot ranges v2 api

    Previously, only QPS was included in the hot ranges v2 api. This commit
    adds the following range statistics to the API:
    
    ```
    WritesPerSecond
    ReadsPerSecond
    WriteBytesPerSecond
    ReadBytesPerSecond
    CPUTimePerSecond
    ```
    
    See the associated comments in `status.proto` for a description of each
    load statistic.
    
    These may be used to determine the hottest ranges. Note however that
    these are sorted by default by QPS. The ordering of ranges w.r.t the new
    load statistics has no guarantees. Likewise, ranges may be omitted which
    have high relative values for the new load statistics but relatively low
    QPS. In practice however, there usually exists a strong correlation that
    ensures that such ranges would not be omitted entirely.
    
    resolves: cockroachdb#95383
    
    Release note: None
    kvoli committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    134463b View commit details
    Browse the repository at this point in the history