streamingccl: redact ssl cert parameters in job description #95835
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
stevendanna
requested review from
a team and
benbardin
and removed request for
a team
stevendanna
force-pushed
the
redact-ssl-params-in-streaming-job-desc
branch
from
982a704
to
8fa377f
Compare
adityamaru
approved these changes
Jan 30, 2023
stevendanna
force-pushed
the
redact-ssl-params-in-streaming-job-desc
branch
from
8fa377f
to
eb8f2d1
Compare
stevendanna
force-pushed
the
redact-ssl-params-in-streaming-job-desc
branch
from
eb8f2d1
to
983588e
Compare
This redacts ssl related query parameter from the job description of
the stream ingestion job. We want these redacted because if the user
is using an sslinline URL they will contain the certificate and key
content itself.
One may claim that we really only need to redact sslkey in the case of
sslinline=true. But, many users get spooked by seeing anything that
looks like a security related artifact in these jobs descriptions, so
I've opted to redact:
sslkey
sslcert
sslrootcert
Epic: none
Release note: None
stevendanna
force-pushed
the
redact-ssl-params-in-streaming-job-desc
branch
from
983588e
to
81c7719
Compare
|
Good call, added the extra test. bors r=adityamaru |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redacts ssl related query parameter from the job description of the stream ingestion job. We want these redacted because if the user is using an sslinline URL they will contain the certificate and key content itself.
One may claim that we really only need to redact sslkey in the case of sslinline=true. But, many users get spooked by seeing anything that looks like a security related artifact in these jobs descriptions, so I've opted to redact:
Epic: none
Release note: None