Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

backup: fail instead of pausing when out of retries #96673

Merged
merged 1 commit into from
Feb 7, 2023
Merged

backup: fail instead of pausing when out of retries #96673

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions pkg/ccl/backupccl/backup_job.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -722,14 +722,12 @@ func (b *backupResumer) Resume(ctx context.Context, execCtx interface{}) error {
}
}

// We have exhausted retries, but we have not seen a "PermanentBulkJobError" so
// it is possible that this is a transient error that is taking longer than
// our configured retry to go away.
//
// Let's pause the job instead of failing it so that the user can decide
// whether to resume it or cancel it.
// We have exhausted retries without getting a "PermanentBulkJobError", but
// something must be wrong if we keep seeing errors so give up and fail to
// ensure that any alerting on failures is triggered and that any subsequent
// schedule runs are not blocked.
if err != nil {
return jobs.MarkPauseRequestError(errors.Wrap(err, "exhausted retries"))
return errors.Wrap(err, "exhausted retries")
}

var backupDetails jobspb.BackupDetails
Expand Down