Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: fix SHOW GRANTS FOR public #96957

Merged
merged 1 commit into from Feb 10, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Feb 10, 2023

fixes #96948

Release note (bug fix): Fixed the SHOW GRANTS FOR public command so it works correctly. Previously, this would return an error saying that the public role does not exist.

@rafiss rafiss added backport-22.1.x 22.1 is EOL backport-22.2.x Flags PRs that need to be backported to 22.2. labels Feb 10, 2023
@rafiss rafiss requested review from ecwall and a team February 10, 2023 16:39
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (bug fix): Fixed the `SHOW GRANTS FOR public` command so it
works correctly. Previously, this would return an error saying that the
`public` role does not exist.
@rafiss
Copy link
Collaborator Author

rafiss commented Feb 10, 2023

flake is #96978

bors r=ecwall

@craig
Copy link
Contributor

craig bot commented Feb 10, 2023

Build failed:

@rafiss
Copy link
Collaborator Author

rafiss commented Feb 10, 2023

bors r=ecwall

@craig craig bot merged commit 8c2060c into cockroachdb:master Feb 10, 2023
@craig
Copy link
Contributor

craig bot commented Feb 10, 2023

Build succeeded:

@blathers-crl
Copy link

blathers-crl bot commented Feb 10, 2023

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from f555196 to blathers/backport-release-22.1-96957: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.1.x failed. See errors above.


error creating merge commit from f555196 to blathers/backport-release-22.2-96957: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 22.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.1.x 22.1 is EOL backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sql: support listing grants for role 'public'
3 participants