roachtest: use qps splitting for splits/load tests #97542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
kvoli
changed the title
kvoli
force-pushed
the
230222.roachtest-split-flake
branch
2 times, most recently
from
5b0006c
to
e386458
Compare
kvoli
requested review from
herkolategan,
srosenberg and
andrewbaptist
and removed request for
a team
shralex
approved these changes
Feb 23, 2023
|
bors r=shralex |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
This commit updates the clusters used in `splits/load` roachtests to use QPS load based splitting, rather than CPU, which was enabled by default in cockroachdb#97424. These tests were failing as they assumed QPS load based splitting when calculating the number of final ranges to assert against. These tests should be run against all load based split objectives, this is tracked in cockroachdb#97540. Resolves: cockroachdb#97494 Resolves: cockroachdb#97455 Informs: cockroachdb#97540 Release note: None
kvoli
force-pushed
the
230222.roachtest-split-flake
branch
from
e386458
to
0df5ea5
Compare
|
bors r=shralex |
|
Build failed: |
|
bors r=shralex |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit updates the clusters used in
splits/loadroachtests to useQPS load based splitting, rather than CPU, which was enabled by default
in #97424.
These tests were failing as they assumed QPS load based splitting when
calculating the number of final ranges to assert against.
These tests should be run against all load based split objectives, this
is tracked in #97540.
Resolves: #97494
Resolves: #97455
Informs: #97540