execinfra: admission control interface #97598
Draft
+274
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
sumeerbhola
force-pushed
the
sql_admission
branch
from
c401908
to
ab7904c
Compare
Informs cockroachdb#85471 Epic: none Release note: None
sumeerbhola
force-pushed
the
sql_admission
branch
from
ab7904c
to
d54004f
Compare
sumeerbhola
commented
Feb 23, 2023
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @DrewKimball and @irfansharif)
pkg/sql/execinfra/admission.go line 177 at r2 (raw file):
// the operator that will call into KV for the batch. // Next steps (in sequence):
The code in this file is super trivial, and the question is whether the reasoning is somewhat sound, and whether we can instrument the SQL code in this manner. I've listed the next steps here.
@irfansharif the first TODO is yours. Happy to discuss synchronously.
This encompasses KV, SQL-KV and SQL-SQL. Epic: none Release note: None
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Informs #85471
Epic: none
Release note: None