Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sqlstats: increase default value for deleted rows #97724

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Feb 27, 2023

Backport 1/1 commits from #97642 on behalf of @maryliag.

/cc @cockroachdb/release


During the sql stats compaction job, we limit the amount of rows being deleted per transaction. We used a default value of 1024, but we have been increasinly seeing customer needing to increase this value to allow the job to keep up with the large amount of data being flushed.
We have been recommening a value for 20k, so being more conservative with the default (plus the changes on #97123 that won't let tables get in a state with so many rows), this commit changes the value to 10k.

Fixes #97528

Release note (sql change): Increase the default value of sql.stats.cleanup.rows_to_delete_per_txn to 10k, to increase efficiency of the cleanup job for sql statistics.


Release justification: performance improvement

During the sql stats compaction job, we limit the amount of
rows being deleted per transaction. We used a default value
of 1024, but we have been increasinly seeing customer needing
to increase this value to allow the job to keep up with the
large amount of data being flushed.
We have been recommening a value for 20k, so being more
conservative with the default (plus the changes on #97123
that won't let tables get in a state with so many rows),
this commit changes the value to 10k.

Fixes #97528

Release note (sql change): Increase the default value of
`sql.stats.cleanup.rows_to_delete_per_txn` to 10k, to increase
efficiency of the cleanup job for sql statistics.
@blathers-crl blathers-crl bot requested a review from a team February 27, 2023 16:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-97642 branch 2 times, most recently from 7cab0fc to fd3f89d Compare February 27, 2023 16:18
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 27, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested review from j82w and maryliag February 27, 2023 16:18
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Feb 27, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Feb 27, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@maryliag maryliag merged commit 200c7d8 into release-22.2 Feb 27, 2023
@maryliag maryliag deleted the blathers/backport-release-22.2-97642 branch February 27, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants