Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: builtins: fix errors with database names with hyphens and/or quotes #97937

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 2, 2023

Backport 1/1 commits from #97915 on behalf of @lopezator.

/cc @cockroachdb/release


Using a database name with a hyphen or quotes is allowed,
but you have to escape it properly to make it work.

There was a problem with the builtins taking the current
database name as an implicit arg, specifically:

  • show_create_all_schemas
  • show_create_all_tables
  • show_create_all_types

Escaping the database name using lexbase.EscapeSQLIdent
ensures the database name is always valid, allowing database names
with hyphens or quotes to being used with the mentioned builtins
safely from now on.

Closes #97914

Release note (bug fix): Fixed the SHOW CREATE ALL {TYPES|SCHEMAS|TABLES} commands
so they handle database names that have mixed-case, hyphens, or quotes.


Release justification: bug fix

Using a database name with a hyphen or quotes is allowed,
but you have to escape it properly to make it work.

There was a problem with the builtins taking the current
database name as an implicit arg, specifically:

- show_create_all_schemas
- show_create_all_tables
- show_create_all_types

Escaping the database name using `lexbase.EscapeSQLIdent`
ensures the database name is always valid, allowing database names
with hyphens or quotes to being used with the mentioned builtins
safely from now on.

Closes #97914

Release note (bug fix): Fixed the SHOW CREATE ALL {TYPES|SCHEMAS|TABLES} commands
so they handle database names that have mixed-case, hyphens, or quotes.
@blathers-crl blathers-crl bot requested a review from a team March 2, 2023 20:17
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-97915 branch from 4beea3e to fc2e9fe Compare March 2, 2023 20:17
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 2, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot requested a review from rafiss March 2, 2023 20:17
@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 2, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@rafiss rafiss merged commit c7ff6f1 into release-22.2 Mar 2, 2023
@rafiss rafiss deleted the blathers/backport-release-22.2-97915 branch March 2, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants