release-22.2: builtins: fix errors with database names with hyphens and/or quotes #97937
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #97915 on behalf of @lopezator.
/cc @cockroachdb/release
Using a database name with a hyphen or quotes is allowed,
but you have to escape it properly to make it work.
There was a problem with the builtins taking the current
database name as an implicit arg, specifically:
Escaping the database name using
lexbase.EscapeSQLIdent
ensures the database name is always valid, allowing database names
with hyphens or quotes to being used with the mentioned builtins
safely from now on.
Closes #97914
Release note (bug fix): Fixed the SHOW CREATE ALL {TYPES|SCHEMAS|TABLES} commands
so they handle database names that have mixed-case, hyphens, or quotes.
Release justification: bug fix