Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

server: add store metrics info to /api/v2/nodes api #98208

Merged
merged 1 commit into from
Apr 4, 2023
Merged

server: add store metrics info to /api/v2/nodes api #98208

merged 1 commit into from
Apr 4, 2023

Conversation

koorosh
Copy link
Collaborator

@koorosh koorosh commented Mar 8, 2023

This patch extends response for /api/v2/nodes api with storeMetrics field which contains map of metrics per each store for every node.
Current change allows to align data provided by "v2" api and _status/nodes api.

Release note (general change): extend /api/v2/nodes api with storeMetrics field.

Resolve: #96216

@koorosh koorosh requested review from dhartunian and a team March 8, 2023 14:05
@koorosh koorosh requested a review from a team as a code owner March 8, 2023 14:05
@blathers-crl
Copy link

blathers-crl bot commented Mar 8, 2023

Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@blathers-crl blathers-crl bot added the O-community Originated from the community label Mar 8, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@Xiang-Gu
Copy link
Contributor

Xiang-Gu commented Mar 8, 2023 •
edited
Loading

Hi @cockroachdb/storage this seems to touch storage-owned code. Can someone take a look?

@Xiang-Gu Xiang-Gu requested review from a team and RaduBerinde March 8, 2023 21:56
dhartunian
dhartunian approved these changes Mar 16, 2023
View reviewed changes
Copy link
Collaborator

@dhartunian dhartunian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @RaduBerinde)

@koorosh koorosh force-pushed the api-v2-nodes-w-store-metrics branch from 993a42e to 31324fc Compare March 17, 2023 15:56
@blathers-crl
Copy link

blathers-crl bot commented Mar 17, 2023

Thank you for updating your pull request.

My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@koorosh koorosh force-pushed the api-v2-nodes-w-store-metrics branch from 31324fc to 34372a4 Compare March 20, 2023 11:43
@koorosh
Copy link
Collaborator Author

koorosh commented Mar 20, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 20, 2023

Build failed:

@koorosh
server: add store metrics info to /api/v2/nodes api
5359199 
This patch extends response for `/api/v2/nodes` api with
`storeMetrics` field which contains map of metrics per
each store for every node.
Current change allows to align data provided by "v2" api
and `_status/nodes` api.

Release note (general change): extend `/api/v2/nodes` api
with `storeMetrics` field.

Signed-off-by: Andrii Vorobiov <and.vorobiov@gmail.com>
@koorosh koorosh force-pushed the api-v2-nodes-w-store-metrics branch from 34372a4 to 5359199 Compare March 27, 2023 07:53
@koorosh
Copy link
Collaborator Author

koorosh commented Mar 27, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 27, 2023

Build failed:

@koorosh
Copy link
Collaborator Author

koorosh commented Mar 27, 2023 •
edited
Loading

bors r+

@craig
Copy link
Contributor

craig bot commented Apr 4, 2023

This PR was included in a batch that timed out, it will be automatically retried

@craig
Copy link
Contributor

craig bot commented Apr 4, 2023

Build succeeded:

@craig craig bot merged commit 713eb47 into cockroachdb:master Apr 4, 2023
@cockroach-teamcity cockroach-teamcity mentioned this pull request Apr 5, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhartunian dhartunian dhartunian approved these changes

@RaduBerinde RaduBerinde Awaiting requested review from RaduBerinde RaduBerinde was automatically assigned from cockroachdb/storage

Assignees
No one assigned
Labels
O-community Originated from the community
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

metrics: /api/v2/nodes/ endpoint omits store-level metrics
4 participants
@koorosh @cockroach-teamcity @Xiang-Gu @dhartunian