Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

insights transactions: undefined (reading 'length') #98222

Merged
merged 1 commit into from Mar 8, 2023
Merged

insights transactions: undefined (reading 'length') #98222

merged 1 commit into from Mar 8, 2023

Conversation

j82w
Copy link
Contributor

@j82w j82w commented Mar 8, 2023

Fixes an issue where if the first query string is null or undefined it will cause the page to fail.

Error:
ErrorBoundary::componentDidCatch] error = TypeError: Cannot read properties of undefined (reading 'length')

Epic: none
Closes: #98188

Release note (ui change): Fixes the `Cannot read properties of undefined (reading 'length')`` error which can cause pages to fail to load.

Release justification: bug fix

Fixes an issue where if the first query string is null or
undefined it will cause the page to fail.

Error:
ErrorBoundary::componentDidCatch] error =  TypeError: Cannot
read properties of undefined (reading 'length')

Epic: none
Closes: #98188

Release note (ui change): Fixes the `Cannot read properties
of undefined (reading 'length')`` error which can cause pages
to fail to load.

Release justification: bug fix
@j82w j82w added the backport-22.2.x Flags PRs that need to be backported to 22.2. label Mar 8, 2023
@j82w j82w requested a review from a team March 8, 2023 16:25
@j82w j82w requested a review from a team as a code owner March 8, 2023 16:25
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@maryliag maryliag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @j82w)

@j82w
Copy link
Contributor Author

j82w commented Mar 8, 2023

bors r+

@craig
Copy link
Contributor

craig bot commented Mar 8, 2023

Build succeeded:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-22.2.x Flags PRs that need to be backported to 22.2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

insights transactions 22.2.6: undefined (reading 'length')
3 participants