Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql/schmachanger: use more friendly language for fallback #98258

Merged
merged 1 commit into from
Mar 10, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 8, 2023

Backport 1/1 commits from #98112 on behalf of @fqazi.

/cc @cockroachdb/release


Previously, the declarative schema changer used slightly
alarming language when falling back. To address this,
this patch removes the word failure and uses softer
language. Also, the logging level is reduced to remove
this message by default.

Fixes: #97922

Release note (bug fix): Previously the declarative schema changer would emit alarming
messages of the form: "failed building declarative schema change targets for". These
were non-severe in nature and now disabled by default.


Release justification: low risk disabling excessive logging.

@blathers-crl blathers-crl bot requested a review from a team March 8, 2023 22:56
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-22.2-98112 branch from f709ae7 to aa1ccaf Compare March 8, 2023 22:56
@blathers-crl blathers-crl bot requested a review from ajwerner March 8, 2023 22:56
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 8, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 8, 2023
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 8, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @fqazi)

Copy link
Contributor

@ajwerner ajwerner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I could see a release note if you felt like it.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @fqazi)

@fqazi
Copy link
Collaborator

fqazi commented Mar 10, 2023

I could see a release note if you felt like it.

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @fqazi)

Yes, let me add a release note for this one

Previously, the declarative schema changer used slightly
alarming language when falling back. To address this,
this patch removes the word failure and uses softer
language. Also the logging level is reduced to remove
this message by default.

Fixes: #97922

Release note (bug fix): Previously the declarative schema changer
would emit alarming messages of the form: "failed building
declarative schema change targets for". These were non-severe
in nature and now disabled by defaulta.

Release note: None
@fqazi fqazi force-pushed the blathers/backport-release-22.2-98112 branch from aa1ccaf to ced3aad Compare March 10, 2023 20:31
@fqazi fqazi merged commit b2b7363 into release-22.2 Mar 10, 2023
@fqazi fqazi deleted the blathers/backport-release-22.2-98112 branch March 10, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants