-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: sql/schmachanger: use more friendly language for fallback #98258
Conversation
f709ae7
to
aa1ccaf
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @fqazi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could see a release note if you felt like it.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @chengxiong-ruan and @fqazi)
Yes, let me add a release note for this one |
Previously, the declarative schema changer used slightly alarming language when falling back. To address this, this patch removes the word failure and uses softer language. Also the logging level is reduced to remove this message by default. Fixes: #97922 Release note (bug fix): Previously the declarative schema changer would emit alarming messages of the form: "failed building declarative schema change targets for". These were non-severe in nature and now disabled by defaulta. Release note: None
aa1ccaf
to
ced3aad
Compare
Backport 1/1 commits from #98112 on behalf of @fqazi.
/cc @cockroachdb/release
Previously, the declarative schema changer used slightly
alarming language when falling back. To address this,
this patch removes the word failure and uses softer
language. Also, the logging level is reduced to remove
this message by default.
Fixes: #97922
Release note (bug fix): Previously the declarative schema changer would emit alarming
messages of the form: "failed building declarative schema change targets for". These
were non-severe in nature and now disabled by default.
Release justification: low risk disabling excessive logging.