Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: add VIEWACTIVITY/VIEWACTIVITREDACTED permission for ranges_no_leases #98645

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

THardy98
Copy link
Contributor

@THardy98 THardy98 commented Mar 15, 2023

Backport 1/1 commits from #98535.

/cc @cockroachdb/release


Fixes: #98514

This change adds the VIEWACTIVITY and VIEWACTIVITYREDACTED permissions access to ranges_no_leases. This allows users to view range data, necessary to use popular console pages:

  • databases page
  • database details page
  • database table page

Prior to this change, users with VIEWACTIVITY/VIEWACTIVITYREDACTED would not be able to view these pages (would show error notification).

Release note (bug fix): Allow users with
VIEWACTIVITY/VIEWACTIVITYREDACTED permissions to access ranges_no_leases table, necessary to view important console pages (databases, database details, and database table pages).

Release justification: Category 2: Bug fixes and low-risk updates to new functionality

@THardy98 THardy98 requested review from maryliag, rafiss and a team March 15, 2023 01:39
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@cockroach-teamcity
Copy link
Member

This change is Reviewable

…eases`

Fixes: cockroachdb#98514

This change adds the `VIEWACTIVITY` and `VIEWACTIVITYREDACTED`
permissions access to `ranges_no_leases`. This allows users to view
range data, necessary to use popular console pages:
- databases page
- database details page
- database table page

Prior to this change, users with `VIEWACTIVITY`/`VIEWACTIVITYREDACTED`
would not be able to view these pages (would show error notification).

Release note (bug fix): Allow users with
`VIEWACTIVITY`/`VIEWACTIVITYREDACTED` permissions to access
`ranges_no_leases` table, necessary to view important console pages
(databases, database details, and database table pages).
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @rafiss)

Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ty for the cleanup!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@THardy98
Copy link
Contributor Author

tyfr :)

@THardy98 THardy98 merged commit 1f19637 into cockroachdb:release-22.2 Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants