-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: sql: add VIEWACTIVITY/VIEWACTIVITREDACTED permission for ranges_no_leases
#98645
release-22.2: sql: add VIEWACTIVITY/VIEWACTIVITREDACTED permission for ranges_no_leases
#98645
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
e33836e
to
2644a61
Compare
…eases` Fixes: cockroachdb#98514 This change adds the `VIEWACTIVITY` and `VIEWACTIVITYREDACTED` permissions access to `ranges_no_leases`. This allows users to view range data, necessary to use popular console pages: - databases page - database details page - database table page Prior to this change, users with `VIEWACTIVITY`/`VIEWACTIVITYREDACTED` would not be able to view these pages (would show error notification). Release note (bug fix): Allow users with `VIEWACTIVITY`/`VIEWACTIVITYREDACTED` permissions to access `ranges_no_leases` table, necessary to view important console pages (databases, database details, and database table pages).
2644a61
to
7866ef3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @maryliag and @rafiss)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ty for the cleanup!
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @maryliag)
tyfr :) |
Backport 1/1 commits from #98535.
/cc @cockroachdb/release
Fixes: #98514
This change adds the
VIEWACTIVITY
andVIEWACTIVITYREDACTED
permissions access toranges_no_leases
. This allows users to view range data, necessary to use popular console pages:Prior to this change, users with
VIEWACTIVITY
/VIEWACTIVITYREDACTED
would not be able to view these pages (would show error notification).Release note (bug fix): Allow users with
VIEWACTIVITY
/VIEWACTIVITYREDACTED
permissions to accessranges_no_leases
table, necessary to view important console pages (databases, database details, and database table pages).Release justification: Category 2: Bug fixes and low-risk updates to new functionality