Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: changefeedccl: fix kafka external connections #98680

Merged

Conversation

HonoreDB
Copy link
Contributor

@HonoreDB HonoreDB commented Mar 15, 2023

Fixes #98679.
The flow for external connection sinks in 22.2.6 ends up calling .Dial() twice, which causes the Kafka sink to hang on Close. This is fixed by more elaborate
refactors in the current version but this is a simple targeted fix for backporting only.

Release note (enterprise change): Fixed a bug preventing the creation of changefeeds to external:// URIs.

Release justification: Low-impact bug fix.

Fixes cockroachdb#98679.
The flow for external connection sinks in 22.2.6 ends
up calling .Dial() twice, which causes the Kafka sink
to hang on Close. This is fixed by more elaborate
refactors in the current version but this is a simple
targeted fix for backporting only.

Release note (enterprise change): Fixed a bug preventing the creation of changefeeds to external:// URIs.
@HonoreDB HonoreDB requested a review from a team as a code owner March 15, 2023 15:39
@HonoreDB HonoreDB requested review from jayshrivastava and removed request for a team March 15, 2023 15:39
@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl
Copy link

blathers-crl bot commented Mar 15, 2023

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@HonoreDB HonoreDB requested a review from miretskiy March 15, 2023 15:40
@HonoreDB
Copy link
Contributor Author

TFTR! Will merge assuming extended CI passes.

@HonoreDB HonoreDB merged commit 5660a05 into cockroachdb:release-22.2 Mar 15, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants