Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-23.1: cluster-ui: fix table details create statement query #99434

Merged
merged 1 commit into from Mar 24, 2023
Merged

release-23.1: cluster-ui: fix table details create statement query #99434

merged 1 commit into from Mar 24, 2023

Conversation

blathers-crl[bot]
Copy link

@blathers-crl blathers-crl bot commented Mar 23, 2023 •
edited by THardy98

Backport 1/1 commits from #99394 on behalf of @THardy98.

/cc @cockroachdb/release

Previously, the create statement query was expecting a statement field, however, the correct field was create_statement. This discrepancy would cause the table details page to load with a blank create statement. The change in this PR rectifies this discrepancy.

Release note (ui change, bug fix): fix a bug where the table's create statement would not display correctly on the table details page.

Release justification: bug fix

@THardy98
cluster-ui: fix table details create statement query
74b926e 
Previously, the create statement query was expecting a `statement`
field, however, the correct field was `create_statement`. This
discrepancy would cause the table details page to load with a blank
create statement. The change in this PR rectifies this discrepancy.

Release note (ui change, bug fix): fix a bug where the table's create
statement would not display correctly on the table details page.

https://cockroachlabs.atlassian.net/browse/DOC-1355 #Informs:
#33316 #Epic: CRDB-8035
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99394 branch from 0704108 to 2af9fcc Compare March 23, 2023 21:13
@blathers-crl blathers-crl bot requested a review from a team as a code owner March 23, 2023 21:13
@blathers-crl blathers-crl bot force-pushed the blathers/backport-release-23.1-99394 branch from 60b774b to 74b926e Compare March 23, 2023 21:13
@blathers-crl blathers-crl bot requested review from j82w and maryliag March 23, 2023 21:13
@blathers-crl
Copy link
Author

blathers-crl bot commented Mar 23, 2023 •
edited by THardy98

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@blathers-crl blathers-crl bot added blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot. labels Mar 23, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

j82w
j82w approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@j82w j82w left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @maryliag)

@THardy98 THardy98 merged commit 50e81f0 into release-23.1 Mar 24, 2023
6 checks passed
@THardy98 THardy98 deleted the blathers/backport-release-23.1-99394 branch March 24, 2023 13:54
@cockroach-teamcity cockroach-teamcity mentioned this pull request Mar 25, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@j82w j82w j82w approved these changes

@maryliag maryliag Awaiting requested review from maryliag

Assignees

@THardy98 THardy98

Labels
blathers-backport This is a backport that Blathers created automatically. O-robot Originated from a bot.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cockroach-teamcity @j82w @THardy98