Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvserver: use qps for hot ranges sorting #99716

Merged
merged 1 commit into from
Mar 30, 2023

Commits on Mar 30, 2023

  1. kvserver: use qps for hot ranges sorting

    We introduced CPU balancing by default in cockroachdb#97424. This had the side
    effect of changing the hot ranges api to return the hottest replicas by
    CPU, rather than QPS.
    
    This patch updates the replica rankings struct to support tracking both
    by CPU and QPS simultaneously. The hot ranges API collects the top k by
    QPS and the store rebalancer collects depending on the setting of
    `kv.allocator.load_based_rebalancing.objective`, which is by default
    `cpu`.
    
    Resolves: cockroachdb#99605
    
    Release note (bug fix): The hot ranges UI page would show hot ranges by
    CPU and not QPS, depending on the value of
    `kv.allocator.load_based_rebalancing.objective` (default `cpu`). Now the
    UI page will always collect based on QPS.
    kvoli committed Mar 30, 2023
    Configuration menu
    Copy the full SHA
    41e3497 View commit details
    Browse the repository at this point in the history