-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-22.2: sql: add version gate for ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS #99845
release-22.2: sql: add version gate for ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS #99845
Conversation
Thanks for opening a backport. Please check the backport criteria before merging:
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
Add a brief release justification to the body of your PR to justify this backport. Some other things to consider:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we merge this to master
as well since currently BinaryMinSupportedVersionKey
is V22_2
?
Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained
We shouldn't need to -- v22.2 nodes will all be able to handle the statement fine. The issue is if you run this ALTER DEFAULT PRIVILEGES COMMAND on a v22.2 node while there are also v22.1 nodes in the cluster. |
8da2592
to
93a9585
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see, I guess I was worried about the case of a v22.1/v23.1 mixed-version cluster, but I guess we aren't supporting version skipping until v22.2.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
-- commits
line 2 at r2:
nit: change ,,,
to ...
Release note (bug fix): The `ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS ...` command is no longer allowed unless all nodes are running on v22.2 and the upgrade is finalized. This prevents a bug where executing this command in a mixed version cluster could cause nodes still running on v22.1 to crash.
93a9585
to
7871538
Compare
fixes #99728
Release justification: critical bug fix
Release note (bug fix): The
ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS ...
command is no longer allowed unless all nodes are running on v22.2 and the upgrade is finalized. This prevents a bug where executing this command in a mixed version cluster could cause nodes still running on v22.1 to crash.