Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-22.2: sql: add version gate for ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS #99845

Merged
merged 1 commit into from
Mar 28, 2023

Conversation

rafiss
Copy link
Collaborator

@rafiss rafiss commented Mar 28, 2023

fixes #99728
Release justification: critical bug fix

Release note (bug fix): The ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS ... command is no longer allowed unless all nodes are running on v22.2 and the upgrade is finalized. This prevents a bug where executing this command in a mixed version cluster could cause nodes still running on v22.1 to crash.

@rafiss rafiss requested review from andyyang890 and a team March 28, 2023 19:13
@blathers-crl
Copy link

blathers-crl bot commented Mar 28, 2023

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Patches should only be created for serious issues or test-only changes.
  • Patches should not break backwards-compatibility.
  • Patches should change as little code as possible.
  • Patches should not change on-disk formats or node communication protocols.
  • Patches should not add new functionality.
  • Patches must not add, edit, or otherwise modify cluster versions; or add version gates.
If some of the basic criteria cannot be satisfied, ensure that the exceptional criteria are satisfied within.
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters.
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.

Add a brief release justification to the body of your PR to justify this backport.

Some other things to consider:

  • What did we do to ensure that a user that doesn’t know & care about this backport, has no idea that it happened?
  • Will this work in a cluster of mixed patch versions? Did we test that?
  • If a user upgrades a patch version, uses this feature, and then downgrades, what happens?

@rafiss rafiss changed the title release-22.2: sql: add version gate for ALTER DEFAULT PRIVILEGES ,,, ON FUNCTIONS release-22.2: sql: add version gate for ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS Mar 28, 2023
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we merge this to master as well since currently BinaryMinSupportedVersionKey is V22_2?

Reviewed 3 of 5 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained

@rafiss
Copy link
Collaborator Author

rafiss commented Mar 28, 2023

Should we merge this to master as well since currently BinaryMinSupportedVersionKey is V22_2?

We shouldn't need to -- v22.2 nodes will all be able to handle the statement fine. The issue is if you run this ALTER DEFAULT PRIVILEGES COMMAND on a v22.2 node while there are also v22.1 nodes in the cluster.

@rafiss rafiss force-pushed the gate-default-priv-function branch from 8da2592 to 93a9585 Compare March 28, 2023 20:14
Copy link
Collaborator

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see, I guess I was worried about the case of a v22.1/v23.1 mixed-version cluster, but I guess we aren't supporting version skipping until v22.2.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @rafiss)


-- commits line 2 at r2:
nit: change ,,, to ...

Release note (bug fix): The `ALTER DEFAULT PRIVILEGES ... ON FUNCTIONS
...` command is no longer allowed unless all nodes are running on v22.2
and the upgrade is finalized. This prevents a bug where executing this
command in a mixed version cluster could cause nodes still running on
v22.1 to crash.
@rafiss rafiss force-pushed the gate-default-priv-function branch from 93a9585 to 7871538 Compare March 28, 2023 21:19
@rafiss rafiss merged commit 2064a8c into cockroachdb:release-22.2 Mar 28, 2023
@rafiss rafiss deleted the gate-default-priv-function branch March 28, 2023 21:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants