Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly handle Skip in sub-test #10

Merged
merged 1 commit into from
Nov 29, 2019
Merged

Properly handle Skip in sub-test #10

merged 1 commit into from
Nov 29, 2019

Conversation

knz
Copy link
Contributor

@knz knz commented Nov 28, 2019 •
edited
Loading

🤦‍♂️ I should really have tested this earlier.

Needed for cockroachdb/cockroach#42152

This change is Reviewable

@knz knz requested review from tbg and RaduBerinde November 28, 2019 09:40
@knz knz mentioned this pull request Nov 28, 2019
Merged
@knz knz mentioned this pull request Nov 28, 2019
Closed
@knz
Copy link
Contributor Author

knz commented Nov 29, 2019

thanks

@knz knz merged commit 4f559e7 into cockroachdb:master Nov 29, 2019
@knz knz deleted the 20191128-skip branch November 29, 2019 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaduBerinde RaduBerinde RaduBerinde approved these changes

@tbg tbg Awaiting requested review from tbg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@knz @RaduBerinde