Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add newline in error message between code position and failed input line #38

Merged
merged 1 commit into from
Mar 26, 2022
Merged

Add newline in error message between code position and failed input line #38

merged 1 commit into from
Mar 26, 2022

Conversation

msbutler
Copy link
Contributor

@msbutler msbutler commented Mar 25, 2022 •
edited by jlinder
Loading

Fixes #37

This change is Reviewable

@msbutler msbutler requested a review from knz March 25, 2022 00:52
knz
knz approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@knz knz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks

@msbutler msbutler merged commit cef0a97 into cockroachdb:master Mar 26, 2022
@msbutler msbutler deleted the butler-newline branch March 26, 2022 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knz knz knz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add newline in error message between code path and actual failed line in test file
2 participants
@msbutler @knz