Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update install page with link to binaries #34

Closed
jseldess opened this issue Feb 4, 2016 · 15 comments
Closed

update install page with link to binaries #34

jseldess opened this issue Feb 4, 2016 · 15 comments
Milestone

Comments

@jseldess
Copy link
Contributor

jseldess commented Feb 4, 2016

For OS X and Linux, Download the Binary needs a valid link.

@bdarnell, @mberhault: When do you think OS X and Linux binaries will be ready, and where will we host them for user download?

@jseldess jseldess added this to the beta milestone Feb 4, 2016
@jseldess jseldess changed the title update install page with valid link to binaries update install page with link to binaries Feb 4, 2016
@mberhault
Copy link
Contributor

we can have them ready anytime you like, we just need to decide how often to rebuild them and how. If it's manual, we can easily build and push to www.cockroachlabs.com. If it's automated, we may be better off putting them in AWS.

@andreimatei
Copy link
Contributor

Should we distribute i386 and amd64 binaries?

On Mon, Feb 8, 2016 at 2:21 PM, marc notifications@github.com wrote:

we can have them ready anytime you like, we just need to decide how often
to rebuild them and how. If it's manual, we can easily build and push to
www.cockroachlabs.com. If it's automated, we may be better off putting
them in AWS.


Reply to this email directly or view it on GitHub
#34 (comment).

@bdarnell
Copy link
Contributor

bdarnell commented Feb 8, 2016

According to a note in CONTRIBUTING.md, we only support 64-bit builds. I'm not sure what the issue is, but it seems safe to go 64-bit only.

@jseldess
Copy link
Contributor Author

jseldess commented Feb 9, 2016

Good to know we're ready whenever. @jess-edwards and I are planning to do a soft-release of the docs as early as next week, so can you guys choose a location, push them there, and post links here by Monday or Tuesday?

@mberhault
Copy link
Contributor

ok, finally getting back to this. I'll be tweaking various S3 paths and naming schemes, so I'll probably be breaking some of my nightly scripts, but here's a proposal for the ultimate goal:

  • build linux/osx binaries for every master commit that passes the tests
  • build a tarball containing only the binary (eg: expands to cockroach/cockroach.linux.amd64)
  • push tarball to S3 bucket: binaries.cockroachdb.com with sha included in the filename
  • update a fixed filename in S3 to redirect to the SHA-based name. eg: binaries.cockroachdb.com/cockroach.linux.amd64.tgz redirects to binaries.cockroachdb.com/cockroach.BUILD-SHA.linux.amd64.tgz
  • setup S3 bucket binaries.cockroachdb.com with static website hosting (allows redirects to work)
  • setup cloudfront to serve binaries.cockroachdb.com using AWS-generated SSL certs. this should make https://binaries.cockroachdb.com/ work properly with a recognized CA.

The download page will simply link to the fixed binary name (the redirect should take care of going to the right one). eg:

@mberhault
Copy link
Contributor

ok, the redirect doesn't work so well with cloudfront. I may have to write to the final filename right away (eg: upload directly to s3://binaries.cockroachdb.com/cockroach.linux-amd64.tgz). The only issue here is what happens when concurrent circle-ci runs step all over each other. S3 will usually drop one of them but can sometimes result in an empty file.

@mberhault
Copy link
Contributor

@jseldess: the binaries are up and will be refreshed for every commit to master that passes the tests.
The permanent links are:
Linux binary: https://binaries.cockroachdb.com/cockroach.linux-amd64.tgz
OSX binary: https://binaries.cockroachdb.com/cockroach.darwin-10.9-amd64.tgz

@jseldess
Copy link
Contributor Author

Excellent. Thanks very much, @mberhault! I'll add those links in today.

@mberhault
Copy link
Contributor

we'll also need to change the instructions. the downloads tar gzipped tarballs, so people will need to do the following:

  • click on the link to download
  • extract the tarball: $ tar xfz cockroach.linux-amd64.tgz
  • move to the directory: $ cd cockroach/
  • run the binary: $ ./cockroach ...

no chmod needed.

@jseldess
Copy link
Contributor Author

@mberhault, when I extract the tarball, the directory created is called cockroach and the binary inside is given the same name as the tarball. It seems unnecessarily complicated to run a binary called ./cockroach.darwin-10.9-amd64 start.

@bdarnell suggested that we should be doing the opposite: extracting the tarball should create a directory with the same name as the tarball, but the binary in that directory should just be cockroach. Can you change that behavior?

@mberhault
Copy link
Contributor

ok. will do.

@mberhault
Copy link
Contributor

Renamed the binary per suggestions. We now have:
cockroach.darwin-10.9-amd64/cockroach
and:
cockroach.linux-amd64/cockroach

Leaving open since this about docs, not the binaries themselves.

@mberhault mberhault reopened this Mar 10, 2016
@mberhault
Copy link
Contributor

oh, and it may take a little while for the new binaries to be effective, cloudfront caching is a little pesky.

@jseldess
Copy link
Contributor Author

Thanks, Marc.

jseldess pushed a commit that referenced this issue Mar 11, 2016
Jseldess/download binary - fixes issue #34
@jseldess
Copy link
Contributor Author

Resolved with PR #113

Simran-B pushed a commit to Simran-B/docs that referenced this issue Jul 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants