Push tarball of linux/osx binaries to s3://binaries.cockroachdb.com #5094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These will be the links used on the download page. We still push linux-only binaries to the current bucket. binaries.cockroachdb.com is special because it is used by cloudfront which provides https. Download links will end up being: https://binaries.cockroachdb.com/cockroach.{linux,darwin-10.9}-amd64.tgz
| ./push-one-binary.sh ${SHA} sql/sql${OSARCH}.test | ||
| ./push-one-binary.sh ${SHA} acceptance/acceptance${OSARCH}.test | ||
| ./push-one-binary.sh ${SHA} static-tests${OSARCH}.tar.gz | ||
| # Linux binaries: cockroach + tests. |
There was a problem hiding this comment.
I am intentionally dropping the (currently unused) OSARCH bit. We're only pushing those binaries for linux.
|
LGTM. Some duplication of variables, but OSX doesn't bump their versions all that often. |
mberhault
added a commit
that referenced
this pull request
Mar 10, 2016
Push tarball of linux/osx binaries to s3://binaries.cockroachdb.com
|
Tarballs linked from Install CockroachDB. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These will be the links used on the download page.
We still push linux-only binaries to the current bucket.
binaries.cockroachdb.com is special because it is used by cloudfront
which provides https.
Download links will end up being:
https://binaries.cockroachdb.com/cockroach.{linux,darwin-10.9}-amd64.tgz
See discussion in cockroachdb/docs#34
This change is