Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MH] Support mutations/CRUD in cost-based optimizer #3998

Closed
jseldess opened this issue Nov 5, 2018 · 1 comment
Closed

[MH] Support mutations/CRUD in cost-based optimizer #3998

jseldess opened this issue Nov 5, 2018 · 1 comment
Assignees
@rmloveland
Labels
P-1 High priority; must be done this release
Milestone
19.1

Comments

@jseldess
Copy link
Contributor

jseldess commented Nov 5, 2018

Background: https://airtable.com/tblD3oZPLJgGhCmch/viw5Jsp2TrY3it9Yr/recNRIzZOB081eanC
PM: @awoods187
Eng: @andy-kimball
@jseldess jseldess added this to the 2.2 milestone Nov 5, 2018
@jseldess jseldess added the P-1 High priority; must be done this release label Nov 20, 2018
@rmloveland rmloveland added P-0 Urgent; must be done in next 2 weeks P-1 High priority; must be done this release and removed P-1 High priority; must be done this release P-0 Urgent; must be done in next 2 weeks labels Dec 4, 2018
rmloveland added a commit that referenced this issue Jan 14, 2019
@rmloveland
Update optimizer docs for 20190114 alpha
3e3d38b 
Fixes #3996, #3998, #4238.

Summary of changes:

- Add section about table statistics, including:

   - How to generate statistics manually

   - How to use the new automatic statistics feature

- Add section describing the new query plan cache and how to use it.

- Add section listing the types of statements supported by the
  optimizer.  This is not exhaustive, but is meant to be a quick list of
  the types of statements supported by the optimizer.  It points the
  user to the "View query plan" section which has instructions for
  checking whether their query will be run with the optimizer.  When the
  heuristic planner is removed, this section can go away.

- Further deemphasize the heuristic planner by:

   - No longer mentioning that the optimizer is "Enabled by default",
     since its use is assumed in 2.2+.

   - Moving the instructions for turning off the CBO to the bottom of
     the page.
@rmloveland rmloveland mentioned this issue Jan 14, 2019
Merged
rmloveland added a commit that referenced this issue Jan 14, 2019
@rmloveland
Update optimizer docs for 20190114 alpha
6fcaad0 
Fixes #3996, #3998, #4238.

Summary of changes:

- Add section about table statistics, including:

   - How to generate statistics manually

   - How to use the new automatic statistics feature

- Add section describing the new query plan cache and how to use it.

- Add section listing the types of statements supported by the
  optimizer.  This is not exhaustive, but is meant to be a quick list of
  the types of statements supported by the optimizer.  It points the
  user to the "View query plan" section which has instructions for
  checking whether their query will be run with the optimizer.  When the
  heuristic planner is removed, this section can go away.

- Further deemphasize the heuristic planner by:

   - No longer mentioning that the optimizer is "Enabled by default",
     since its use is assumed in 2.2+.

   - Moving the instructions for turning off the CBO to the bottom of
     the page.
rmloveland added a commit that referenced this issue Jan 15, 2019
@rmloveland
Update optimizer docs for 20190115 alpha
62d2731 
Fixes #3996, #3998, #4238.

Summary of changes:

- Add section about table statistics, including:

   - How to generate statistics manually

   - How to use the new automatic statistics feature

- Add section describing the new query plan cache and how to use it.

- Add section listing the types of statements supported by the
  optimizer.  This is not exhaustive, but is meant to be a quick list of
  the types of statements supported by the optimizer.  It points the
  user to the "View query plan" section which has instructions for
  checking whether their query will be run with the optimizer.  When the
  heuristic planner is removed, this section can go away.

- Further deemphasize the heuristic planner by:

   - No longer mentioning that the optimizer is "Enabled by default",
     since its use is assumed in 2.2+.

   - Moving the instructions for turning off the CBO to the bottom of
     the page.
rmloveland added a commit that referenced this issue Jan 16, 2019
@rmloveland
Update optimizer docs for 20190115 alpha
255886d 
Fixes #3996, #3998, #4238.

Summary of changes:

- Add section about table statistics, including:

   - How to generate statistics manually

   - How to use the new automatic statistics feature

- Add section describing the new query plan cache and how to use it.

- Add section listing the types of statements supported by the
  optimizer.  This is not exhaustive, but is meant to be a quick list of
  the types of statements supported by the optimizer.  It points the
  user to the "View query plan" section which has instructions for
  checking whether their query will be run with the optimizer.  When the
  heuristic planner is removed, this section can go away.

- Further deemphasize the heuristic planner by:

   - No longer mentioning that the optimizer is "Enabled by default",
     since its use is assumed in 2.2+.

   - Moving the instructions for turning off the CBO to the bottom of
     the page.
rmloveland added a commit that referenced this issue Feb 7, 2019
@rmloveland
Update CBO docs to list more supported statements
a9492f6 
A bit more work to address #3998.

Summary of changes:

- Edit the 'Supported statements' section of the ['Cost-based
  Optimizer'][1] page to add:

  - Add FILTER per cockroachdb/cockroach#34077

  - Add DELETE per cockroachdb/cockroach#34522

  - Add `INSERT .. ON CONFLICT` variants per cockroachdb/cockroach#33339

[1]: http://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html
rmloveland added a commit that referenced this issue Feb 7, 2019
@rmloveland
Update CBO docs to list more supported statements
9c77ef6 
A bit more work to address #3998.

Summary of changes:

- Edit the 'Supported statements' section of the ['Cost-based
  Optimizer'][1] page as follows:

  - Add FILTER per cockroachdb/cockroach#34077

  - Add DELETE per cockroachdb/cockroach#34522

  - Add `INSERT .. ON CONFLICT` variants per cockroachdb/cockroach#33339

  - Remove `experimental_optimizer_updates` cluster setting (can't find
    a commit for this, but I don't see it in `SHOW ALL` output on my
    local build of yesterday's `master`, version number is
    `v2.2.0-alpha.20181217-1096-gd104dcee69-dirty`.

[1]: http://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html
@rmloveland rmloveland mentioned this issue Feb 7, 2019
Merged
rmloveland added a commit that referenced this issue Feb 8, 2019
@rmloveland
Update CBO docs to list more supported statements
a3a12af 
A bit more work to address #3998.

Summary of changes:

- Edit the 'Supported statements' section of the ['Cost-based
  Optimizer'][1] page as follows:

  - Add DELETE per cockroachdb/cockroach#34522

  - Add `INSERT .. ON CONFLICT` variants per cockroachdb/cockroach#33339

  - Add FILTER clause on aggregate functions per
    cockroachdb/cockroach#34077

  - Remove `experimental_optimizer_updates` cluster setting (can't find
    a commit for this, but I don't see it in `SHOW ALL` output on my
    local build of yesterday's `master`, version number is
    `v2.2.0-alpha.20181217-1096-gd104dcee69-dirty`.

[1]: http://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html
rmloveland added a commit that referenced this issue Feb 11, 2019
@rmloveland
Update CBO docs to list more supported statements
c5fb63b 
A bit more work to address #3998.

Summary of changes:

- Edit the 'Supported statements' section of the ['Cost-based
  Optimizer'][1] page as follows:

  - Add DELETE per cockroachdb/cockroach#34522

  - Add `INSERT .. ON CONFLICT` variants per cockroachdb/cockroach#33339

  - Add `SELECT`, `VALUES`, and `UNION` statements that do not include
    window functions

  - Add FILTER clause on aggregate functions per
    cockroachdb/cockroach#34077

  - Remove `experimental_optimizer_updates` cluster setting

[1]: http://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html
rmloveland added a commit that referenced this issue Feb 11, 2019
@rmloveland
Update CBO docs to list more supported statements
7fbce7b 
A bit more work to address #3998.

Summary of changes:

- Edit the 'Supported statements' section of the ['Cost-based
  Optimizer'][1] page as follows:

  - Add DELETE per cockroachdb/cockroach#34522

  - Add `INSERT .. ON CONFLICT` variants per cockroachdb/cockroach#33339

  - Add `SELECT`, `VALUES`, and `UNION` statements that do not include
    window functions

  - Add FILTER clause on aggregate functions per
    cockroachdb/cockroach#34077

  - Remove `experimental_optimizer_updates` cluster setting

[1]: http://www.cockroachlabs.com/docs/v2.2/cost-based-optimizer.html
@jseldess jseldess modified the milestones: 2.2, 19.1 Feb 25, 2019
@rmloveland
Copy link
Contributor

Based on comparing the statements listed in the AirTable entry with our docs on the types of statements supported by the optimizer, I think this work is done.

@awoods187 and/or @andy-kimball, please re-open if you think more docs work is needed here.

@rmloveland rmloveland mentioned this issue Mar 7, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
P-1 High priority; must be done this release
Projects
None yet
Milestone
19.1
Development

No branches or pull requests
2 participants
@rmloveland @jseldess