opt: Prune Update and Upsert input columns

[andy-kimball]

Prune input columns that are not needed by Update and Upsert operators.
Needed columns include returned columns and columns needed to formulate
KV Put and Delete operations to implement the mutations. All other
columns can be pruned.

This commit contains new code to enable the Upsert fast path with the
CBO. The fast path uses the KV Put method to blindly insert new rows
or overwrite existing rows. Because any existing data is ignored, it is
not necessary to fetch existing rows, as is normally required. This
also allows a much simpler logical plan.

After this change, the optimizer updates/upserts no longer need to stay
behind a feature flag, as all fast paths should now work at least as
well as they do with the heuristic planner.

Release note (sql change): Delete, Update, and Upsert statements are
now planned by the cost-based optimizer.

[cockroach-teamcity]

This change is 

[rytaft]

Reviewed 16 of 16 files at r1, 16 of 16 files at r2, 28 of 28 files at r3, 12 of 12 files at r4.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @andy-kimball, @justinj, and @RaduBerinde)

---

pkg/sql/opt_catalog.go, line 364 at r1 (raw file):

	stats []optTableStat

	// family is the inlined wrapper for the table's primary family, where

this comment got cut off.

---

pkg/sql/opt_catalog.go, line 367 at r1 (raw file):

	primaryFamily optFamily

	// families is a cache of family wrappers (all except default family) that's

is default family the same as primaryFamily?

---

pkg/sql/opt_exec_factory.go, line 1077 at r3 (raw file):

	var fkCheckType row.FKCheckType
	if len(updateColDescs) == 0 {
		fkCheckType = row.CheckInserts

Is there no longer a possibility that we only need to check inserts?

---

pkg/sql/opt/cat/family.go, line 1 at r1 (raw file):

// Copyright 2018 The Cockroach Authors.

[nit] 2019

---

pkg/sql/opt/cat/table.go, line 128 at r1 (raw file):

	// FamilyCount returns the number of column families present on the table.
	// There is always at least one primary family (always family 0) where columns
	// go if they are not explicitly assigned to another family.

What if all columns are explicitly assigned? Is there still a primary family?

---

pkg/sql/opt/optbuilder/mutation_builder.go, line 413 at r2 (raw file):

	if needResults {
		// Only non-mutation columns are output columns.
		private.ReturnCols = make(opt.ColList, mb.tab.DeletableColumnCount())

shouldn't this be ColumnCount()?

---

pkg/sql/opt/testutils/testcat/create_table.go, line 72 at r1 (raw file):

	}

	// Add non-mutation columns and families.

I don't see where the families are getting added here.

[andy-kimball]

Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @justinj, @RaduBerinde, and @rytaft)

---

pkg/sql/opt_catalog.go, line 364 at r1 (raw file):

Previously, rytaft wrote…

this comment got cut off.

Done.

---

pkg/sql/opt_catalog.go, line 367 at r1 (raw file):

Previously, rytaft wrote…

is default family the same as primaryFamily?

Done.

---

pkg/sql/opt_exec_factory.go, line 1077 at r3 (raw file):

Previously, rytaft wrote…

Is there no longer a possibility that we only need to check inserts?

No, there shouldn't be any such possibility. We map that case into an Insert.

---

pkg/sql/opt/cat/family.go, line 1 at r1 (raw file):

Previously, rytaft wrote…

[nit] 2019

Done.

---

pkg/sql/opt/cat/table.go, line 128 at r1 (raw file):

Previously, rytaft wrote…

What if all columns are explicitly assigned? Is there still a primary family?

The primary family is always the first family that was explicitly defined, or if no families were defined, then a primary family is synthesized. I added to the comment.

---

pkg/sql/opt/optbuilder/mutation_builder.go, line 413 at r2 (raw file):

Previously, rytaft wrote…

shouldn't this be ColumnCount()?

No, the length of these column lists is always DeletableColumnCount, but missing columns are set to 0. So in this case the length is DeletableColumnCount, but we only fill in the first ColumnCount entries. I added to the comment.

---

pkg/sql/opt/testutils/testcat/create_table.go, line 72 at r1 (raw file):

Previously, rytaft wrote…

I don't see where the families are getting added here.

Done.

[andy-kimball]

bors r+

[craig]

Merge conflict (retrying...)

[craig]

Build succeeded

• GitHub CI (Cockroach)