Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document that optimizer query cache is on by default for v2.2.0-alpha-20190211 #4334

Closed
rmloveland opened this issue Feb 7, 2019 · 0 comments
Closed

Document that optimizer query cache is on by default for v2.2.0-alpha-20190211 #4334

rmloveland opened this issue Feb 7, 2019 · 0 comments
Assignees
@rmloveland
Labels
P-0 Urgent; must be done in next 2 weeks

Comments

@rmloveland
Copy link
Contributor

rmloveland commented Feb 7, 2019 •
edited
Loading

The query plan cache is turned on by default as of this release.

We should update the query cache docs to note this fact.

While there, we should revisit the list of limitations from the last release to make sure they're still relevant, and remove them if not.

EDIT: Following limitations appear to have been lifted:

See also:
@rmloveland rmloveland self-assigned this Feb 7, 2019
@rmloveland rmloveland added A-sql P-0 Urgent; must be done in next 2 weeks labels Feb 7, 2019
rmloveland added a commit that referenced this issue Feb 7, 2019
@rmloveland
Document that query cache is enabled by default
fa67b1b 
Fixes #4334.

Summary of changes:

- Update 'Query plan cache' section of the CBO page as follows:

  - Query cache is now enabled by default

  - BUGFIX: Updated example to use `SET CLUSTER SETTING`, was using
    `SET`

  - Removed the following limitations since (if I'm reading PRs
    correctly) they no longer exist:

     - Invalidate cached plans when stats
       change (cockroachdb/cockroach#34057)

     - Query cache works for prepared
       stmts (cockroachdb/cockroach#33575)
@rmloveland rmloveland mentioned this issue Feb 7, 2019
Merged
rmloveland added a commit that referenced this issue Feb 11, 2019
@rmloveland
Document that query cache is enabled by default
0e8f9fa 
Fixes #4334.

Summary of changes:

- Update 'Query plan cache' section of the CBO page as follows:

  - Query cache is now enabled by default

  - BUGFIX: Updated example to use `SET CLUSTER SETTING`, was using
    `SET`

  - Removed the following limitations since (if I'm reading PRs
    correctly) they no longer exist:

     - Invalidate cached plans when stats
       change (cockroachdb/cockroach#34057)

     - Query cache works for prepared
       stmts (cockroachdb/cockroach#33575)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmloveland rmloveland

Labels
P-0 Urgent; must be done in next 2 weeks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rmloveland