Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FAQ about decision to use Postgres protocol #1845

Merged
merged 2 commits into from
Aug 20, 2017
Merged

Add FAQ about decision to use Postgres protocol #1845

merged 2 commits into from
Aug 20, 2017

Conversation

jseldess
Copy link
Contributor

Fixes #1839

@jseldess jseldess requested a review from bdarnell August 18, 2017 15:57
@cockroach-teamcity
Copy link
Member

This change is Reviewable

@@ -125,6 +125,12 @@ CockroachDB supports the PostgreSQL wire protocol, so you can use any available

See [Install Client Drivers](install-client-drivers.html) for more details.

## Why does CockroachDB use the PostgreSQL wire protocol instead of the MySQL protocol?

CockroachDB uses the PostgreSQL wire protocol because it is better documented than the MySQL protocol and the PostgreSQL license is better for us than the MySQL license.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PostgreSQL uses the PostgreSQL license: "a liberal Open Source license, similar to the BSD or MIT licenses."

MySQL is licensed under the GPL which is much more restrictive. @bdarnell can provide better words here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated using more of your language, in the meantime.

@bdarnell
Copy link
Contributor

:lgtm:


Review status: 0 of 2 files reviewed at latest revision, 1 unresolved discussion, all commit checks successful.


Comments from Reviewable

@jseldess jseldess merged commit fbf00ed into master Aug 20, 2017
@jseldess jseldess deleted the mysql-faq branch August 20, 2017 01:34
@tamird
Copy link
Contributor

tamird commented Aug 24, 2017

@jseldess assuming the bullet about better documentation is referencing our dinner conversation, I believe the original reason was that postgres' dialect was better documented than mysql's.

Not sure this needs fixing, but wanted to clarify, in case I was the cause of misconception.

@bdarnell
Copy link
Contributor

This came from an answer I gave on the forum, and I was referring to the protocol being better documented.

@jseldess
Copy link
Contributor Author

Haha, meant to mention at dinner that I'd added that FAQ. Thanks for finding it, @tamird.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants