Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs for session/cluster/table cdc filtering for row-level ttl v23.2 & v24.1 #18496

Merged
merged 6 commits into from
Apr 30, 2024

Conversation

kathancox
Copy link
Contributor

@kathancox kathancox commented Apr 23, 2024

Fixes DOC-9705, DOC-8055

This PR adds new docs to v23.2 and v24.1 around the filtering of TTL job deletes from changefeeds. There are differences in what is available between the versions. v24.1 has the addition of the changefeed option and table storage parameter.

Added examples and descriptions to the option tables.

Rendered Previews

row-level ttl page

create changefeed page

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cockroachdb-api-docs canceled.

Name Link
🔨 Latest commit c3e6d0c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-api-docs/deploys/66313cc267f6710008074478

Copy link

netlify bot commented Apr 23, 2024

Deploy Preview for cockroachdb-interactivetutorials-docs canceled.

Name Link
🔨 Latest commit c3e6d0c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-interactivetutorials-docs/deploys/66313cc258c4a90009b42bc0

Copy link

github-actions bot commented Apr 23, 2024

Copy link

netlify bot commented Apr 23, 2024

Netlify Preview

Name Link
🔨 Latest commit c3e6d0c
🔍 Latest deploy log https://app.netlify.com/sites/cockroachdb-docs/deploys/66313cc2b3a5ba000849b14a
😎 Deploy Preview https://deploy-preview-18496--cockroachdb-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating the docs! Left a few comments.

src/current/_includes/v23.2/cdc/disable-replication-ttl.md Outdated Show resolved Hide resolved
src/current/v24.1/row-level-ttl.md Show resolved Hide resolved
src/current/_includes/v24.1/cdc/disable-replication-ttl.md Outdated Show resolved Hide resolved
Copy link

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding it to the table of session variables!

src/current/_includes/v23.2/cdc/disable-replication-ttl.md Outdated Show resolved Hide resolved
src/current/v23.2/changefeed-messages.md Show resolved Hide resolved
src/current/_includes/v24.1/cdc/disable-replication-ttl.md Outdated Show resolved Hide resolved
Copy link

@andyyang890 andyyang890 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@florence-crl florence-crl self-requested a review April 30, 2024 13:54
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending suggestions.

src/current/_includes/v24.1/cdc/disable-replication-ttl.md Outdated Show resolved Hide resolved
src/current/v23.2/changefeed-messages.md Outdated Show resolved Hide resolved
src/current/v23.2/changefeed-messages.md Outdated Show resolved Hide resolved
src/current/v24.1/changefeed-messages.md Outdated Show resolved Hide resolved
Copy link
Contributor

@florence-crl florence-crl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason my last suggestion did not save. Here it is.

src/current/v24.1/create-changefeed.md Outdated Show resolved Hide resolved
@kathancox kathancox merged commit df17963 into main Apr 30, 2024
6 checks passed
@kathancox kathancox deleted the session-filtering-cdc branch April 30, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants