-
Notifications
You must be signed in to change notification settings - Fork 453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--temp-dir flag #2955
--temp-dir flag #2955
Conversation
Closes #2163.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with a few nits.
v2.0/start-a-node.md
Outdated
`--pid-file` | The file to which the node's process ID will be written on successful startup. When this flag is not set, the process ID is not written to file. | ||
`--port`<br>`-p` | The port to bind to for internal and client communication.<br><br>To have an unused port assigned automatically, pass `--port=0`.<br><br>**Env Variable:** `COCKROACH_PORT`<br>**Default:** `26257` | ||
`--store`<br>`-s` | The file path to a storage device and, optionally, store attributes and maximum size. When using multiple storage devices for a node, this flag must be specified separately for each device, for example: <br><br>`--store=/mnt/ssd01 --store=/mnt/ssd02` <br><br>For more details, see [Store](#store) below. | ||
`--temp-dir` | <span class="version-tag">New in v2.0:</span> The path of the given node's temporary store directory. On node start up, the location for the temporary files is printed to the standard output. <br><br>**Default:** Subdirectory of the first [store](#store) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: The path of the given node's temporary...
> The path of the node's temporary...
v2.0/start-a-node.md
Outdated
@@ -140,6 +143,8 @@ Field | Description | |||
`admin` | The URL for accessing the Admin UI. | |||
`sql` | The connection URL for your client. | |||
`logs` | The directory containing debug log data. | |||
`temp dir` | The temporary store directory of the node. | |||
`external I/O path` | The external IO directory with which the local file access paths are prefixed while performing backup and restore operations using local node directories or NFS drives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind making "backup" and "restore" link to the backup.html
and restore.html
?
v2.1/start-a-node.md
Outdated
`--pid-file` | The file to which the node's process ID will be written on successful startup. When this flag is not set, the process ID is not written to file. | ||
`--port`<br>`-p` | The port to bind to for internal and client communication.<br><br>To have an unused port assigned automatically, pass `--port=0`.<br><br>**Env Variable:** `COCKROACH_PORT`<br>**Default:** `26257` | ||
`--store`<br>`-s` | The file path to a storage device and, optionally, store attributes and maximum size. When using multiple storage devices for a node, this flag must be specified separately for each device, for example: <br><br>`--store=/mnt/ssd01 --store=/mnt/ssd02` <br><br>For more details, see [Store](#store) below. | ||
`--temp-dir` | <span class="version-tag">New in v2.0:</span> The path of the given node's temporary store directory. On node start up, the location for the temporary files is printed to the standard output. <br><br>**Default:** Subdirectory of the first [store](#store) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
v2.1/start-a-node.md
Outdated
@@ -140,6 +143,8 @@ Field | Description | |||
`admin` | The URL for accessing the Admin UI. | |||
`sql` | The connection URL for your client. | |||
`logs` | The directory containing debug log data. | |||
`temp dir` | The temporary store directory of the node. | |||
`external I/O path` | The external IO directory with which the local file access paths are prefixed while performing backup and restore operations using local node directories or NFS drives. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above.
Review status: 0 of 2 files reviewed at latest revision, 4 unresolved discussions, all commit checks successful. v2.0/start-a-node.md, line 65 at r1 (raw file): Previously, jseldess (Jesse Seldess) wrote…
Done. v2.0/start-a-node.md, line 147 at r1 (raw file): Previously, jseldess (Jesse Seldess) wrote…
Done. v2.1/start-a-node.md, line 65 at r1 (raw file): Previously, jseldess (Jesse Seldess) wrote…
Done. v2.1/start-a-node.md, line 147 at r1 (raw file): Previously, jseldess (Jesse Seldess) wrote…
Done. Comments from Reviewable |
Closes #2163.