Update 2.1 diagnostics reporting page #3737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dt
approved these changes
Sep 12, 2018
v2.1/diagnostics-reporting.md
Outdated
| - Stores on the node | ||
| - Hardware the node is running on | ||
| - Structure of tables stored on the node | ||
| - SQL queries executed by the node |
There was a problem hiding this comment.
Tiny nit: I might say ‘types of SQL queries...’ just to reinforce that they’re not the raw queries, just the structure. I know we also talk about the string scrubbing a few lines later, but lazy readers like me might be skimming or someone might see that line out of context and be alarmed.
kannanlakshmi
approved these changes
Sep 12, 2018
There was a problem hiding this comment.
Thanks Jesse, LGTM!
Reviewed 1 of 1 files at r1.
Reviewable status:complete! 0 of 0 LGTMs obtained
jseldess
force-pushed
the
diagnostics
branch
from
3bfd33c
to
c503f18
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace detailed description of each section of diagnostics reporting
with a summary and details about the endnpoint to use to view
details yourself.
Fixes #3695.
Fixes #3080.
Fixes #3062.
Fixes #3597.