Session vars updates #3799
Merged
Session vars updates #3799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
lnhsingh
commented
Oct 1, 2018
There was a problem hiding this comment.
Reviewable status:
complete! 0 of 0 LGTMs obtained
v2.1/set-vars.md, line 58 at r2 (raw file):
`client_min_messages` | Ignored; recognized for compatibility with PostgreSQL clients. Only possible value is `notice`. | N/A | Yes `standard_conforming_strings` | Ignored; recognized for compatibility with PostgreSQL clients. | N/A | Yes `integer_datetimes` | Ignored; recognized for compatibility with PostgreSQL clients. Only possible value is `on`. | N/A | Yes
Should standard_conforming_strings and integer_datetimes have the "New in v2.1" tag? I was thinking no, since they are only there for Postgres compatibility, but would like opinions.
knz
approved these changes
Oct 2, 2018
There was a problem hiding this comment.
Reviewed 2 of 2 files at r2.
Reviewable status:
v2.1/set-vars.md, line 58 at r2 (raw file):
Previously, lhirata wrote…
Should
standard_conforming_stringsandinteger_datetimeshave the "New in v2.1" tag? I was thinking no, since they are only there for Postgres compatibility, but would like opinions.
I agree you do not need to mark them as new.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3614.
Closes #3615.
Closes #3618.