-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v2.1.9 release notes #5370
v2.1.9 release notes #5370
Conversation
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/13727d3e7598f2b9af9a23cfcf2b4bd733910214/ Edited pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with a minor correction
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @jseldess)
_includes/sidebar-releases.json, line 23 at r1 (raw file):
] }, {
You can remove 2.1.8 from the sidenav. We just list the main release and the latest patch.
13727d3
to
a7f36a9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess)
_includes/sidebar-releases.json, line 23 at r1 (raw file):
Previously, jseldess (Jesse Seldess) wrote…
You can remove 2.1.8 from the sidenav. We just list the main release and the latest patch.
Done.
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/a7f36a99042b54b1018821ab6b47444a07d926eb/ Edited pages: |
We should add a note for cockroachdb/cockroach#40353, which went in without one because we didn't grasp its significance when it was originally written. This is the biggest bug fix and the whole reason we're pushing this build now. "Fixed a bug that could lead to data inconsistencies and crashes with the message |
a7f36a9
to
6c92312
Compare
Done! Thanks @bdarnell. |
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/6c923124219b76be78021a6dbf599dd9ca48f575/ Edited pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @jseldess)
Handing this off to you, @rmloveland |
6c92312
to
9febf82
Compare
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/9febf82b73f0a0ef7379fa407abcf17ddee9bdf4/ Edited pages: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM aside from the duplicates.
Fixes #5369.
9febf82
to
0fab7bc
Compare
Online preview: http://cockroach-docs-review.s3-website-us-east-1.amazonaws.com/0fab7bc45c35e40116c6771dfd7e1049e2374361/ Edited pages: |
Thanks Ben. Removed dupes, publishing now. |
releases/v2.1.9.md, line 51 at r2 (raw file):
Duplicate? |
releases/v2.1.9.md, line 50 at r2 (raw file):
Rephrase: Intents in a read's uncertainty interval are now considered uncertain just .... |
releases/v2.1.9.md, line 49 at r2 (raw file):
Fix > Fixed |
releases/v2.1.9.md, line 48 at r2 (raw file):
Duplicate. |
releases/v2.1.9.md, line 47 at r2 (raw file):
This is a duplicate. |
releases/v2.1.9.md, line 46 at r2 (raw file):
This is a duplicate. |
releases/v2.1.9.md, line 45 at r2 (raw file):
Fix > Fixed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Jesse, sorry for not waiting. Wanted to get these out ASAP and got an itchy trigger finger, my bad.
Re: the dupes, I just removed them after Ben's comment.
Re: the copy edits, let's leave it as is (even though they're improvements). I don't want to mess with it now that it's in the process of being published and maybe break something.
Reviewable status:
complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @rmloveland)
Fixes #5369.