Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v2.1.9 release notes #5370

Merged
merged 1 commit into from
Sep 23, 2019
Merged

v2.1.9 release notes #5370

merged 1 commit into from
Sep 23, 2019

Conversation

ericharmeling
Copy link
Contributor

Fixes #5369.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@cockroach-teamcity
Copy link
Member

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with a minor correction

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @jseldess)


_includes/sidebar-releases.json, line 23 at r1 (raw file):

      ]
    },
    {

You can remove 2.1.8 from the sidenav. We just list the main release and the latest patch.

Copy link
Contributor Author

@ericharmeling ericharmeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess)


_includes/sidebar-releases.json, line 23 at r1 (raw file):

Previously, jseldess (Jesse Seldess) wrote…

You can remove 2.1.8 from the sidenav. We just list the main release and the latest patch.

Done.

@cockroach-teamcity
Copy link
Member

@bdarnell
Copy link
Contributor

bdarnell commented Sep 5, 2019

We should add a note for cockroachdb/cockroach#40353, which went in without one because we didn't grasp its significance when it was originally written. This is the biggest bug fix and the whole reason we're pushing this build now.

"Fixed a bug that could lead to data inconsistencies and crashes with the message consistency check failed with N inconsistent replicas."

@ericharmeling
Copy link
Contributor Author

We should add a note for cockroachdb/cockroach#40353, which went in without one because we didn't grasp its significance when it was originally written. This is the biggest bug fix and the whole reason we're pushing this build now.

"Fixed a bug that could lead to data inconsistencies and crashes with the message consistency check failed with N inconsistent replicas."

Done! Thanks @bdarnell.

@cockroach-teamcity
Copy link
Member

Copy link
Contributor

@jseldess jseldess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @jseldess)

@ericharmeling
Copy link
Contributor Author

Handing this off to you, @rmloveland

@cockroach-teamcity
Copy link
Member

@rmloveland
Copy link
Contributor

@bdarnell and @jseldess , mind taking one more pass over these?

Updated with a few new commits and updated the date to 9/23, everything else should be the same, hopefully.

Copy link
Contributor

@bdarnell bdarnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the duplicates.

@cockroach-teamcity
Copy link
Member

@rmloveland
Copy link
Contributor

Thanks Ben. Removed dupes, publishing now.

@rmloveland rmloveland merged commit aae7c58 into master Sep 23, 2019
@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 51 at r2 (raw file):

- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]
- Consider intents in a read's uncertainty interval to be uncertain just as if they were committed values. This removes the potential for stale reads when a causally dependent transaction runs into the not-yet resolved intents from a causal ancestor. [#40632][#40632] [d6b00e37e][d6b00e37e]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]

Duplicate?

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 50 at r2 (raw file):

- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]
- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]
- Consider intents in a read's uncertainty interval to be uncertain just as if they were committed values. This removes the potential for stale reads when a causally dependent transaction runs into the not-yet resolved intents from a causal ancestor. [#40632][#40632] [d6b00e37e][d6b00e37e]

Rephrase: Intents in a read's uncertainty interval are now considered uncertain just ....

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 49 at r2 (raw file):

- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]
- Fix bug where MVCC value at future timestamp is returned after a transaction restart. [#40632][#40632] [9dbb670a8][9dbb670a8]

Fix > Fixed

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 48 at r2 (raw file):

- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]
- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368] [75a8d2468][75a8d2468]

Duplicate.

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 47 at r2 (raw file):

- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]
- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]
- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105] [6f537772c][6f537772c]

This is a duplicate.

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 46 at r2 (raw file):

- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]
- Fixed incorrect results, or "unordered span" errors in some cases involving exclusive inequalities with non-numeric types. [#38897][#38897] [c2919b478][c2919b478]

This is a duplicate.

@jseldess
Copy link
Contributor


releases/v2.1.9.md, line 45 at r2 (raw file):

- Fixed a potential infinite loop in queries involving reverse scans. [#39105][#39105]
- Unary negatives in constant arithmetic expressions are no longer ignored. [#39368][#39368]
- Fix wrong comparator used in RocksDB compaction picker, which can lead to infinite compaction loop. [#40752][#40752] [23459d2c4][23459d2c4]

Fix > Fixed

Copy link
Contributor

@rmloveland rmloveland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Jesse, sorry for not waiting. Wanted to get these out ASAP and got an itchy trigger finger, my bad.

Re: the dupes, I just removed them after Ben's comment.

Re: the copy edits, let's leave it as is (even though they're improvements). I don't want to mess with it now that it's in the process of being published and maybe break something.

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @ericharmeling and @rmloveland)

@rmloveland rmloveland deleted the release-notes-2.1.9 branch September 23, 2019 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

v2.1.9 Release Notes
5 participants