release-2.1: libroach: disable rocksdb subcompactions #40353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
bdarnell
approved these changes
Aug 31, 2019
The feature is not widely used so is not the most stable, especially when combined with other uncommonly used features like range tombstones. In my `bin/workload kv --read-percent 0` experiments it is not necessary since the frequent foreground `fdatasync`s prevent compaction from falling behind, with or without subcompactions enabled. Release note: None
ajkr
force-pushed
the
backport2.1-35210
branch
from
052f38b
to
77de2f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 1/1 commits from #35210.
/cc @cockroachdb/release
The feature is not widely used so is not the most stable, especially
when combined with other uncommonly used features like range tombstones.
In my
bin/workload kv --read-percent 0experiments it is not necessarysince the frequent foreground
fdatasyncs prevent compaction fromfalling behind, with or without subcompactions enabled.
Release note: None