-
Notifications
You must be signed in to change notification settings - Fork 455
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--geo-partitioned-replicas flag #5587
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, save for two small fixes.
v19.2/cockroach-demo.md
Outdated
@@ -64,6 +64,7 @@ Flag | Description | |||
`--echo-sql` | Reveal the SQL statements sent implicitly by the command-line utility. This can also be enabled within the interactive SQL shell via the `\set echo` [shell command](use-the-built-in-sql-client.html#commands). | |||
`--execute`<br>`-e` | Execute SQL statements directly from the command line, without opening a shell. This flag can be set multiple times, and each instance can contain one or more statements separated by semi-colons.<br><br>If an error occurs in any statement, the command exits with a non-zero status code and further statements are not executed. The results of each statement are printed to the standard output (see `--format` for formatting options). | |||
`--format` | How to display table rows printed to the standard output. Possible values: `tsv`, `csv`, `table`, `raw`, `records`, `sql`, `html`.<br><br>**Default:** `table` for sessions that [output on a terminal](use-the-built-in-sql-client.html#session-and-output-types); `tsv` otherwise<br /><br />This flag corresponds to the `display_format` [client-side option](use-the-built-in-sql-client.html#client-side-options) for use in interactive sessions. | |||
`--geo-partitioned-replicas` | <span class="version-tag">New in v19.2:</span> Start a 9-node demo cluster with the [Geo-Partitioned Replicas](topology-geo-partitioned-replicas.html) topology pattern applied to the `movr` database. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mention of movr should probably link to the movr overview page for additional smurfiness.
v19.2/cockroach-demo.md
Outdated
@@ -229,6 +230,15 @@ $ cockroach demo --with-load | |||
|
|||
This command starts a demo cluster with the `movr` database preloaded and then inserts rows into each table in the `movr` database. You can monitor the workload progress on the [Admin UI](admin-ui-overview-dashboard.html#sql-queries). | |||
|
|||
### Run `cockroach demo` with the [Geo-Partitioned Replicas](topology-geo-partitioned-replicas.html) topology pattern |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having the link in the heading's text causes the page's TOC entry to have BIG TEXT (but still lowercase) after the link. Suggest making a shorter heading like "Run cockroach demo with geo-partitioned replicas" and letting the text below do the work of linking since the info is already there. Our style guide is silent on this issue, perhaps I'll make a PR.
- new flag entry - new example
599f0ab
to
c9e44dc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TFTR Rich!
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @rmloveland)
v19.2/cockroach-demo.md, line 67 at r1 (raw file):
Previously, rmloveland (Rich Loveland) wrote…
The mention of movr should probably link to the movr overview page for additional smurfiness.
Done.
v19.2/cockroach-demo.md, line 233 at r1 (raw file):
Previously, rmloveland (Rich Loveland) wrote…
Having the link in the heading's text causes the page's TOC entry to have BIG TEXT (but still lowercase) after the link. Suggest making a shorter heading like "Run cockroach demo with geo-partitioned replicas" and letting the text below do the work of linking since the info is already there. Our style guide is silent on this issue, perhaps I'll make a PR.
Done.
Fixes #5519.