Fix handling of multiple statements. #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This needs a test. |
petermattis
force-pushed
the
pmattis/fix-multiple-results
branch
2 times, most recently
from
0b27271
to
e91e749
Compare
|
Test added. |
| // If set, this connection will not skip returning results for | ||
| // multi-statement queries where one of the statements does not return | ||
| // results such as CREATE TABLE or SET. | ||
| disableSkipZeroResultQueries bool |
There was a problem hiding this comment.
The double negative of disableSkip is hard to parse. How about enableMultipleResults, since that's what you're really opting in to here?
There was a problem hiding this comment.
Yeah, I knew that was the wrong name when writing this. Done.
|
LGTM |
When a query contained multiple statements any statement which did not return data (e.g. `SET`, `CREATE DATABASE`, etc) would be ignored unless it was the last statement.
petermattis
force-pushed
the
pmattis/fix-multiple-results
branch
from
e91e749
to
218e5bd
Compare
petermattis
added a commit
that referenced
this pull request
Feb 25, 2016
Fix handling of multiple statements.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a query contained multiple statements any statement which did not
return data (e.g.
SET,CREATE DATABASE, etc) would be ignored unlessit was the last statement.