Skip to content

Commit

Permalink
util: elide usage of __DATE__
Browse files Browse the repository at this point in the history
Due to bazelbuild/rules_foreign_cc#239, we
elide usage of __DATE__ in RocksDB. It makes our life much easier when
trying to bazel-ify the cockroachdb repo.
  • Loading branch information
irfansharif committed Oct 17, 2020
1 parent 2512e96 commit ec7b666
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 5 deletions.
1 change: 0 additions & 1 deletion db/db_impl.cc
Original file line number Diff line number Diff line change
Expand Up @@ -3369,7 +3369,6 @@ void DumpRocksDBBuildVersion(Logger* log) {
ROCKS_LOG_HEADER(log, "RocksDB version: %d.%d.%d\n", ROCKSDB_MAJOR,
ROCKSDB_MINOR, ROCKSDB_PATCH);
ROCKS_LOG_HEADER(log, "Git sha %s", rocksdb_build_git_sha);
ROCKS_LOG_HEADER(log, "Compile date %s", rocksdb_build_compile_date);
#else
(void)log; // ignore "-Wunused-parameter"
#endif
Expand Down
1 change: 0 additions & 1 deletion util/build_version.cc.in
Original file line number Diff line number Diff line change
Expand Up @@ -2,4 +2,3 @@
#include "build_version.h"
const char* rocksdb_build_git_sha = "rocksdb_build_git_sha:@@GIT_SHA@@";
const char* rocksdb_build_git_date = "rocksdb_build_git_date:@@GIT_DATE_TIME@@";
const char* rocksdb_build_compile_date = __DATE__;
3 changes: 0 additions & 3 deletions util/build_version.h
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,4 @@
// generate these variables
// this variable tells us about the git revision
extern const char* rocksdb_build_git_sha;

// Date on which the code was compiled:
extern const char* rocksdb_build_compile_date;
#endif

0 comments on commit ec7b666

Please sign in to comment.