Potential fix for stress test failure due to "SST file ahead of WAL" error (#5412) #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…error (facebook#5412) This is an unclean backport of facebook#5412. I removed the change to `SyncClosedLogs()` calling `LogWriter::Close()` since our 5.17 branch does not have `LogWriter::Close()` implemented. I believe this is fine to omit because we aren't calling `SyncClosedLogs()` during flush in our single-CF use case.
petermattis
approved these changes
Jun 6, 2019
ajkr
added a commit
to ajkr/cockroach
that referenced
this pull request
Jun 23, 2019
Includes the following changes, all of which have landed upstream. - cockroachdb/rocksdb#32: "Fix merging range tombstone covering put during flush/compaction" - cockroachdb/rocksdb#33: "Dynamic test whether sync_file_range returns ENOSYS" - cockroachdb/rocksdb#34: "Potential fix for stress test failure due to "SST file ahead of WAL" error" - cockroachdb/rocksdb#35: "Avoid deadlock between mutex_ and log_write_mutex_" Fixes cockroachdb#37752. Release note (bug fix): Fixed possible deadlock when storage engine write fails. Release note (bug fix): Fixed potential reappearance of deleted timeseries data, which could trip consistency checker. Release note (bug fix): Removed dependency on `sync_file_range` on Linux platforms on which it returns `ENOSYS`, such as WSL (Windows Subsystem for Linux).
craig bot
pushed a commit
to cockroachdb/cockroach
that referenced
this pull request
Jun 23, 2019
38170: c-deps: bump rocksdb for multiple backported PRs r=ajkr a=ajkr Includes the following changes, all of which have landed upstream. - cockroachdb/rocksdb#32: "Fix merging range tombstone covering put during flush/compaction" - cockroachdb/rocksdb#33: "Dynamic test whether sync_file_range returns ENOSYS" - cockroachdb/rocksdb#34: "Potential fix for stress test failure due to "SST file ahead of WAL" error" - cockroachdb/rocksdb#35: "Avoid deadlock between mutex_ and log_write_mutex_" Fixes #37752. Release note (bug fix): Fixed possible deadlock when storage engine write fails. Release note (bug fix): Fixed potential reappearance of deleted timeseries data, which could trip consistency checker. Release note (bug fix): Removed dependency on `sync_file_range` on Linux platforms on which it returns `ENOSYS`, such as WSL (Windows Subsystem for Linux). Co-authored-by: Andrew Kryczka <andrew.kryczka2@gmail.com>
ajkr
added a commit
to ajkr/cockroach
that referenced
this pull request
Jun 26, 2019
Includes the following changes, all of which have landed upstream. - cockroachdb/rocksdb#32: "Fix merging range tombstone covering put during flush/compaction" - cockroachdb/rocksdb#33: "Dynamic test whether sync_file_range returns ENOSYS" - cockroachdb/rocksdb#34: "Potential fix for stress test failure due to "SST file ahead of WAL" error" - cockroachdb/rocksdb#35: "Avoid deadlock between mutex_ and log_write_mutex_" Fixes cockroachdb#37752. Release note (bug fix): Fixed possible deadlock when storage engine write fails. Release note (bug fix): Fixed potential reappearance of deleted timeseries data, which could trip consistency checker. Release note (bug fix): Removed dependency on `sync_file_range` on Linux platforms on which it returns `ENOSYS`, such as WSL (Windows Subsystem for Linux).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an unclean backport of
facebook#5412. I removed the change to
SyncClosedLogs()callingLogWriter::Close()since our 5.17 branchdoes not have
LogWriter::Close()implemented. I believe this is fineto omit because we aren't calling
SyncClosedLogs()during flush inour single-CF use case.
This change is