Skip to content
This repository has been archived by the owner on Apr 12, 2023. It is now read-only.

Synchronize with the internal repository #258

Merged
merged 1 commit into from
Jun 29, 2021
Merged

Synchronize with the internal repository #258

merged 1 commit into from
Jun 29, 2021

Conversation

cocoa-dev
Copy link
Contributor

@cocoa-dev cocoa-dev commented Jun 28, 2021

Issue 番号 / Issue ID

目的 / Purpose

  • アプリの内部リポジトリのソースコードの変更点を同期します

「処理番号の取得方法」画面の追加

device-2021-06-29-110455

アクセシビリティ対応

スクリーンリーダの挙動を一部修正

破壊的変更をもたらしますか / Does this introduce a breaking change?

[x] Yes
[ ] No

Pull Request の種類 / Pull Request type

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

検証方法 / How to test

コードの入手 / Get the code

git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
dotnet restore

コードの検証 / Test the code


確認事項 / What to check

その他 / Other information

@cocoa-dev cocoa-dev marked this pull request as ready for review June 28, 2021 03:15
@keiji keiji self-requested a review June 28, 2021 03:17
Copy link
Collaborator

@keiji keiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Synchronize with the internal repository
だと変更内容がよくわからないので、コミットコメントに変更概要を記載してください 🌾

- 陽性登録時の「処理番号の取得方法」の画面を変更(追加)
- スクリーンリーダの挙動を一部修正
@cocoa-dev
Copy link
Contributor Author

Synchronize with the internal repository
だと変更内容がよくわからないので、コミットコメントに変更概要を記載してください 🌾

コミットコメントを修正しました

@keiji keiji self-requested a review June 28, 2021 05:19
Copy link
Collaborator

@keiji keiji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@keiji keiji requested review from halsk and heykuro June 28, 2021 05:20
@keiji keiji added this to その他機能改善 / Enhancement in v1.2.5 - 202107 Jun 29, 2021
@keiji keiji moved this from その他機能改善 / Enhancement to プロジェクト整理 / Project Organization in v1.2.5 - 202107 Jun 29, 2021
@keiji keiji merged commit 5d56cfa into develop Jun 29, 2021
@keiji keiji deleted the sync-app-210628 branch June 29, 2021 07:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
No open projects
v1.2.5 - 202107
プロジェクト整理 / Project Organization
Development

Successfully merging this pull request may close these issues.

None yet

2 participants