docs(warpPerspective): enhance with Kino and some text #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cocoa-xu
reviewed
May 6, 2023
examples/warp_perspective.livemd
Outdated
Comment on lines
71
to
81
| @doc """ | ||
| Returns the Euclidean norm. | ||
|
|
||
| ``` | ||
| {:module, Helper, <<70, 79, 82, 49, 0, 0, 10, ...>>, {:download!, 3}} | ||
| ``` | ||
|
|
||
| ## Read the Test Image From File | ||
|
|
||
| ```elixir | ||
| # Download the test image | ||
| test_image_path = Path.join(__DIR__, "warp_perspective.png") | ||
| ## Examples | ||
|
|
||
| Helper.download!( | ||
| "https://raw.githubusercontent.com/cocoa-xu/evision/main/test/testdata/warp_perspective.png", | ||
| test_image_path | ||
| ) | ||
|
|
||
| # Read the test image | ||
| %Evision.Mat{shape: {h, w, _}} = img = Evision.imread(test_image_path) | ||
| ``` | ||
|
|
||
| <!-- livebook:{"output":true} --> | ||
|
|
||
| ``` | ||
| %Evision.Mat{ | ||
| channels: 3, | ||
| dims: 2, | ||
| type: {:u, 8}, | ||
| raw_type: 16, | ||
| shape: {288, 277, 3}, | ||
| ref: #Reference<0.391993608.626655254.103441> | ||
| } | ||
| iex> Helper.hypot([3, 4]) | ||
| 5.0 | ||
| """ | ||
| def hypot([n | _] = numbers) when is_number(n) do | ||
| :math.sqrt(Enum.reduce(numbers, 0, &(&2 + &1 ** 2))) | ||
| end |
There was a problem hiding this comment.
Just a really minor thing here. Should we perhaps still keep it as a lambda function?
# the hypot.(list(number())) function returns the Euclidean norm
hypot = fn n ->
:math.sqrt(Enum.reduce(numbers, 0, &(&2 + &1 ** 2)))
endI'm thinking that it feels more natural to do it this way (writing a lambda function where one needs it)? Moreover, I'm wondering if it would be better to keep functions in Helper only relevant to preparing resources for the livebook?
What do you think?
There was a problem hiding this comment.
That makes sense!
mnishiguchi
force-pushed
the
docs-warp-perspective
branch
from
55fccec
to
9d792ce
Compare
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some enhancement to the warpPerspective notebook. Here are some of the things this PR explores.
Cvalias as in some other documents