Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove --full flag #13

Closed
manuyavuz opened this issue Oct 28, 2015 · 4 comments
Closed

Remove --full flag #13

manuyavuz opened this issue Oct 28, 2015 · 4 comments

Comments

@manuyavuz
Copy link
Member

After the improvements in #8 merged completely, I think we can get rid of --full flag because it would give answer in less than a second in most cases.

@manuyavuz
Copy link
Member Author

@orta We thought about removing --full flag, but I have a small concern.

non-git repositories still won't utilize improvements presented. Their search will still be slow.

However, I do think we can still move --full as default option because I assume users using non-git repos will be much minority.

What about adding a new flag like --simple and moving --full algorithm to default option?

cc: @alloy @floere @segiddins

@segiddins
Copy link
Member

Sounds good to me!

@orta
Copy link
Member

orta commented Oct 29, 2015

Yeah, that's cool for me too

@manuyavuz
Copy link
Member Author

Good then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants